0
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-11-28 23:36:29 +01:00
gitea/routers/web/repo
silverwind 60e4a98ab0
Preserve BOM in web editor (#28935)
The `ToUTF8*` functions were stripping BOM, while BOM is actually valid
in UTF8, so the stripping must be optional depending on use case. This
does:

- Add a options struct to all `ToUTF8*` functions, that by default will
strip BOM to preserve existing behaviour
- Remove `ToUTF8` function, it was dead code
- Rename `ToUTF8WithErr` to `ToUTF8`
- Preserve BOM in Monaco Editor
- Remove a unnecessary newline in the textarea value. Browsers did
ignore it, it seems but it's better not to rely on this behaviour.

Fixes: https://github.com/go-gitea/gitea/issues/28743
Related: https://github.com/go-gitea/gitea/issues/6716 which seems to
have once introduced a mechanism that strips and re-adds the BOM, but
from what I can tell, this mechanism was removed at some point after
that PR.
2024-01-27 18:02:51 +00:00
..
actions
setting Preserve BOM in web editor (#28935) 2024-01-27 18:02:51 +00:00
activity.go
attachment.go
blame.go
branch.go
cherry_pick.go
commit.go Preserve BOM in web editor (#28935) 2024-01-27 18:02:51 +00:00
compare.go Preserve BOM in web editor (#28935) 2024-01-27 18:02:51 +00:00
download.go
editor_test.go
editor.go Preserve BOM in web editor (#28935) 2024-01-27 18:02:51 +00:00
find.go
githttp_test.go
githttp.go
helper_test.go
helper.go
issue_content_history.go
issue_dependency.go
issue_label_test.go
issue_label.go
issue_lock.go
issue_pin.go
issue_stopwatch.go
issue_test.go
issue_timetrack.go
issue_watch.go
issue.go
main_test.go
middlewares.go
migrate.go
milestone.go
packages.go
patch.go
projects_test.go
projects.go
pull_review.go
pull.go
release_test.go
release.go
render.go Preserve BOM in web editor (#28935) 2024-01-27 18:02:51 +00:00
repo.go
search.go
topic.go
treelist.go
view_test.go
view.go Preserve BOM in web editor (#28935) 2024-01-27 18:02:51 +00:00
wiki_test.go
wiki.go