mirror of
https://github.com/go-gitea/gitea.git
synced 2026-10-15 09:35:12 +02:00
Calvin Tjoaquinnandwxiaoguang
8c7b8d085c
The six batched loaders in `IssueList` iterate their rows and never call `rows.Err()`. Refactored the code by a new helper function. --------- Signed-off-by: Calvin Tjoaquinn <calvintjoa23@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
266 lines
12 KiB
Go
266 lines
12 KiB
Go
// Copyright 2017 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package activities_test
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
activities_model "gitea.dev/models/activities"
|
|
"gitea.dev/models/db"
|
|
issues_model "gitea.dev/models/issues"
|
|
repo_model "gitea.dev/models/repo"
|
|
"gitea.dev/models/unittest"
|
|
user_model "gitea.dev/models/user"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestCreateOrUpdateIssueNotifications(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 1})
|
|
|
|
_, err := activities_model.CreateOrUpdateIssueNotifications(t.Context(), issue.ID, 0, 2, 0)
|
|
assert.NoError(t, err)
|
|
|
|
// User 9 is inactive, thus notifications for user 1 and 4 are created
|
|
notf := unittest.AssertExistsAndLoadBean(t, &activities_model.Notification{UserID: 1, IssueID: issue.ID})
|
|
assert.Equal(t, activities_model.NotificationStatusUnread, notf.Status)
|
|
unittest.CheckConsistencyFor(t, &issues_model.Issue{ID: issue.ID})
|
|
|
|
notf = unittest.AssertExistsAndLoadBean(t, &activities_model.Notification{UserID: 4, IssueID: issue.ID})
|
|
assert.Equal(t, activities_model.NotificationStatusUnread, notf.Status)
|
|
}
|
|
|
|
func TestCreateOrUpdateIssueNotificationsForAssigneeAndReviewer(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
// user 13 neither watches repo 1 nor participates in PR 3
|
|
assert.NoError(t, db.Insert(t.Context(), &issues_model.IssueAssignees{AssigneeID: 13, IssueID: 3}))
|
|
_, err := activities_model.CreateOrUpdateIssueNotifications(t.Context(), 3, 0, 1, 0)
|
|
assert.NoError(t, err)
|
|
unittest.AssertExistsAndLoadBean(t, &activities_model.Notification{UserID: 13, IssueID: 3})
|
|
|
|
// user 1 is a requested reviewer of PR 12 and does not participate in it
|
|
_, err = activities_model.CreateOrUpdateIssueNotifications(t.Context(), 12, 0, 2, 0)
|
|
assert.NoError(t, err)
|
|
unittest.AssertExistsAndLoadBean(t, &activities_model.Notification{UserID: 1, IssueID: 12})
|
|
}
|
|
|
|
func TestCreateOrUpdateIssueNotificationsIgnored(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
// user 4 watches repo 1 and would be notified about issue 1
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 4})
|
|
assert.NoError(t, repo_model.WatchRepoWithOptions(t.Context(), user, repo, repo_model.WatchOptions{Mode: repo_model.WatchModeDont}))
|
|
|
|
notified, err := activities_model.CreateOrUpdateIssueNotifications(t.Context(), 1, 0, 2, 0)
|
|
assert.NoError(t, err)
|
|
assert.NotContains(t, notified, user.ID)
|
|
|
|
// muting outranks a direct receiver too
|
|
notified, err = activities_model.CreateOrUpdateIssueNotifications(t.Context(), 1, 0, 2, user.ID)
|
|
assert.NoError(t, err)
|
|
assert.Empty(t, notified)
|
|
}
|
|
|
|
func TestNotificationsSkipBots(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
for _, id := range []int64{4, 28} {
|
|
assert.NoError(t, user_model.UpdateUserCols(t.Context(), &user_model.User{ID: id, Type: user_model.UserTypeBot}, "type"))
|
|
}
|
|
|
|
notifiedIDs, err := activities_model.CreateOrUpdateIssueNotifications(t.Context(), 1, 0, 2, 0)
|
|
assert.NoError(t, err)
|
|
assert.Contains(t, notifiedIDs, int64(1))
|
|
assert.NotContains(t, notifiedIDs, int64(4))
|
|
|
|
doer := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
|
|
org := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 3})
|
|
assert.NoError(t, activities_model.CreateRepoTransferNotification(t.Context(), doer, org, unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 3})))
|
|
unittest.AssertExistsAndLoadBean(t, &activities_model.Notification{UserID: 2, RepoID: 3, Source: activities_model.NotificationSourceRepository})
|
|
unittest.AssertNotExistsBean(t, &activities_model.Notification{UserID: 28, RepoID: 3, Source: activities_model.NotificationSourceRepository})
|
|
|
|
bot := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 4})
|
|
assert.NoError(t, activities_model.CreateRepoTransferNotification(t.Context(), doer, bot, unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})))
|
|
unittest.AssertNotExistsBean(t, &activities_model.Notification{UserID: 4, RepoID: 1, Source: activities_model.NotificationSourceRepository})
|
|
}
|
|
|
|
func TestNotificationsForUser(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
notfs, err := db.Find[activities_model.Notification](t.Context(), activities_model.FindNotificationOptions{
|
|
UserID: user.ID,
|
|
Status: []activities_model.NotificationStatus{
|
|
activities_model.NotificationStatusRead,
|
|
activities_model.NotificationStatusUnread,
|
|
},
|
|
})
|
|
assert.NoError(t, err)
|
|
if assert.Len(t, notfs, 3) {
|
|
assert.EqualValues(t, 5, notfs[0].ID)
|
|
assert.Equal(t, user.ID, notfs[0].UserID)
|
|
assert.EqualValues(t, 4, notfs[1].ID)
|
|
assert.Equal(t, user.ID, notfs[1].UserID)
|
|
assert.EqualValues(t, 2, notfs[2].ID)
|
|
assert.Equal(t, user.ID, notfs[2].UserID)
|
|
}
|
|
}
|
|
|
|
func TestNotificationListLoadAttributes(t *testing.T) {
|
|
require.NoError(t, unittest.PrepareTestDatabase())
|
|
first := &activities_model.Notification{RepoID: 1, IssueID: 1, UserID: 1, CommentID: 2}
|
|
last := &activities_model.Notification{RepoID: 2, IssueID: 4, UserID: 2, CommentID: 8}
|
|
loaded := &activities_model.Notification{
|
|
RepoID: 1, IssueID: 1, UserID: 1, CommentID: 2,
|
|
Repository: &repo_model.Repository{ID: 1},
|
|
Issue: &issues_model.Issue{ID: 1},
|
|
User: &user_model.User{ID: 1},
|
|
Comment: &issues_model.Comment{ID: 2},
|
|
}
|
|
saved := *loaded
|
|
list := activities_model.NotificationList{first}
|
|
var wantFailures []int
|
|
for i := range db.DefaultMaxInSize {
|
|
id := unittest.NonexistentID - int64(i)
|
|
wantFailures = append(wantFailures, len(list))
|
|
list = append(list, &activities_model.Notification{RepoID: id, IssueID: id, UserID: id, CommentID: id})
|
|
}
|
|
withoutIssue := &activities_model.Notification{RepoID: 1}
|
|
list = append(list, last, loaded, withoutIssue)
|
|
|
|
repos, failures, err := list.LoadRepos(t.Context())
|
|
require.NoError(t, err)
|
|
assert.Equal(t, wantFailures, failures)
|
|
require.Len(t, repos, 2)
|
|
assert.Equal(t, int64(1), repos[0].ID)
|
|
assert.Equal(t, int64(2), repos[1].ID)
|
|
failures, err = list.LoadIssues(t.Context())
|
|
require.NoError(t, err)
|
|
assert.Equal(t, wantFailures, failures)
|
|
failures, err = list.LoadUsers(t.Context())
|
|
require.NoError(t, err)
|
|
assert.Empty(t, failures)
|
|
failures, err = list.LoadComments(t.Context())
|
|
require.NoError(t, err)
|
|
assert.Empty(t, failures)
|
|
|
|
for _, notification := range []*activities_model.Notification{first, last} {
|
|
require.NotNil(t, notification.Repository)
|
|
assert.Equal(t, notification.RepoID, notification.Repository.ID)
|
|
require.NotNil(t, notification.Issue)
|
|
assert.Equal(t, notification.IssueID, notification.Issue.ID)
|
|
assert.Same(t, notification.Repository, notification.Issue.Repo)
|
|
require.NotNil(t, notification.User)
|
|
assert.Equal(t, notification.UserID, notification.User.ID)
|
|
require.NotNil(t, notification.Comment)
|
|
assert.Equal(t, notification.CommentID, notification.Comment.ID)
|
|
assert.Same(t, notification.Issue, notification.Comment.Issue)
|
|
}
|
|
assert.Same(t, saved.Repository, loaded.Repository)
|
|
assert.Same(t, saved.Issue, loaded.Issue)
|
|
assert.Same(t, saved.User, loaded.User)
|
|
assert.Same(t, saved.Comment, loaded.Comment)
|
|
for _, notification := range list[1 : db.DefaultMaxInSize+1] {
|
|
assert.Nil(t, notification.Repository)
|
|
assert.Nil(t, notification.Issue)
|
|
assert.Nil(t, notification.User)
|
|
assert.Nil(t, notification.Comment)
|
|
}
|
|
assert.Nil(t, withoutIssue.Issue)
|
|
assert.Nil(t, withoutIssue.User)
|
|
assert.Nil(t, withoutIssue.Comment)
|
|
}
|
|
|
|
func TestNotification_GetRepo(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
notf := unittest.AssertExistsAndLoadBean(t, &activities_model.Notification{RepoID: 1})
|
|
repo, err := notf.GetRepo(t.Context())
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, repo, notf.Repository)
|
|
assert.Equal(t, notf.RepoID, repo.ID)
|
|
}
|
|
|
|
func TestNotification_GetIssue(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
notf := unittest.AssertExistsAndLoadBean(t, &activities_model.Notification{RepoID: 1})
|
|
issue, err := notf.GetIssue(t.Context())
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, issue, notf.Issue)
|
|
assert.Equal(t, notf.IssueID, issue.ID)
|
|
}
|
|
|
|
func TestGetNotificationCount(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
|
|
cnt, err := db.Count[activities_model.Notification](t.Context(), activities_model.FindNotificationOptions{
|
|
UserID: user.ID,
|
|
Status: []activities_model.NotificationStatus{
|
|
activities_model.NotificationStatusRead,
|
|
},
|
|
})
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 0, cnt)
|
|
|
|
cnt, err = db.Count[activities_model.Notification](t.Context(), activities_model.FindNotificationOptions{
|
|
UserID: user.ID,
|
|
Status: []activities_model.NotificationStatus{
|
|
activities_model.NotificationStatusUnread,
|
|
},
|
|
})
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 1, cnt)
|
|
}
|
|
|
|
func TestSetNotificationStatus(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
notf := unittest.AssertExistsAndLoadBean(t,
|
|
&activities_model.Notification{UserID: user.ID, Status: activities_model.NotificationStatusRead})
|
|
_, err := activities_model.SetNotificationStatus(t.Context(), notf.ID, user, activities_model.NotificationStatusPinned)
|
|
assert.NoError(t, err)
|
|
unittest.AssertExistsAndLoadBean(t,
|
|
&activities_model.Notification{ID: notf.ID, Status: activities_model.NotificationStatusPinned})
|
|
|
|
_, err = activities_model.SetNotificationStatus(t.Context(), 1, user, activities_model.NotificationStatusRead)
|
|
assert.Error(t, err)
|
|
_, err = activities_model.SetNotificationStatus(t.Context(), unittest.NonexistentID, user, activities_model.NotificationStatusRead)
|
|
assert.Error(t, err)
|
|
}
|
|
|
|
func TestUpdateNotificationStatuses(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
notfUnread := unittest.AssertExistsAndLoadBean(t,
|
|
&activities_model.Notification{UserID: user.ID, Status: activities_model.NotificationStatusUnread})
|
|
notfRead := unittest.AssertExistsAndLoadBean(t,
|
|
&activities_model.Notification{UserID: user.ID, Status: activities_model.NotificationStatusRead})
|
|
notfPinned := unittest.AssertExistsAndLoadBean(t,
|
|
&activities_model.Notification{UserID: user.ID, Status: activities_model.NotificationStatusPinned})
|
|
_, err := activities_model.UpdateNotificationStatuses(t.Context(), user, activities_model.NotificationStatusUnread, activities_model.NotificationStatusRead)
|
|
assert.NoError(t, err)
|
|
unittest.AssertExistsAndLoadBean(t,
|
|
&activities_model.Notification{ID: notfUnread.ID, Status: activities_model.NotificationStatusRead})
|
|
unittest.AssertExistsAndLoadBean(t,
|
|
&activities_model.Notification{ID: notfRead.ID, Status: activities_model.NotificationStatusRead})
|
|
unittest.AssertExistsAndLoadBean(t,
|
|
&activities_model.Notification{ID: notfPinned.ID, Status: activities_model.NotificationStatusPinned})
|
|
}
|
|
|
|
func TestSetIssueReadBy(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
|
|
issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 1})
|
|
assert.NoError(t, db.WithTx(t.Context(), func(ctx context.Context) error {
|
|
_, err := activities_model.SetIssueReadBy(ctx, issue.ID, user.ID)
|
|
return err
|
|
}))
|
|
|
|
nt, err := activities_model.GetIssueNotification(t.Context(), user.ID, issue.ID)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, activities_model.NotificationStatusRead, nt.Status)
|
|
}
|