0
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-12-12 03:51:16 +01:00
gitea/modules/structs
Jason Song 174213530d
Fix Permission in API returned repository struct (#25388)
The old code generates `structs.Repository.Permissions` with only
`access.Permission.AccessMode`, however, it should check the units too,
or the value could be incorrect. For example,
`structs.Repository.Permissions.Push` could be false even the doer has
write access to code unit.

Should fix
https://github.com/renovatebot/renovate/issues/14059#issuecomment-1047961128
(Not reported by it, I just found it when I was looking into this bug)

---

Review tips:

The major changes are
- `modules/structs/repo.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-870406f6857117f8b03611c43fca0ab9ed6d6e76a2d0069a7c1f17e8fa9092f7
- `services/convert/repository.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-7736f6d2ae894c9edb7729a80ab89aa183b888a26a811a0c1fdebd18726a7101

And other changes are passive.
2023-06-22 13:08:08 +00:00
..
activity.go
activitypub.go
admin_user.go
attachment.go
commit_status.go
cron.go
doc.go
fork.go
git_blob.go
git_hook.go
hook.go
issue_comment.go
issue_label.go
issue_milestone.go
issue_reaction.go
issue_stopwatch.go
issue_test.go
issue_tracked_time.go
issue.go
lfs_lock.go
mirror.go
miscellaneous.go
nodeinfo.go
notifications.go
org_member.go
org_team.go
org.go
package.go
pull_review.go
pull.go
release.go
repo_branch.go
repo_collaborator.go
repo_commit.go
repo_file.go
repo_key.go
repo_note.go
repo_refs.go
repo_tag.go
repo_topic.go
repo_tree.go
repo_watch.go
repo_wiki.go
repo.go
settings.go
status.go
task.go
user_app.go
user_email.go
user_gpgkey.go
user_key.go
user.go
visible_type.go