mirror of
https://github.com/go-gitea/gitea.git
synced 2024-11-30 10:05:10 +01:00
716fcfcf72
A lot of our code is repeatedly testing if individual errors are specific types of Not Exist errors. This is repetitative and unnecesary. `Unwrap() error` provides a common way of labelling an error as a NotExist error and we can/should use this. This PR has chosen to use the common `io/fs` errors e.g. `fs.ErrNotExist` for our errors. This is in some ways not completely correct as these are not filesystem errors but it seems like a reasonable thing to do and would allow us to simplify a lot of our code to `errors.Is(err, fs.ErrNotExist)` instead of `package.IsErr...NotExist(err)` I am open to suggestions to use a different base error - perhaps `models/db.ErrNotExist` if that would be felt to be better. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: delvh <dev.lh@web.de> |
||
---|---|---|
.. | ||
assignees_test.go | ||
assignees.go | ||
comment_list.go | ||
comment_test.go | ||
comment.go | ||
content_history_test.go | ||
content_history.go | ||
dependency_test.go | ||
dependency.go | ||
issue_index.go | ||
issue_list_test.go | ||
issue_list.go | ||
issue_lock.go | ||
issue_project.go | ||
issue_test.go | ||
issue_user_test.go | ||
issue_user.go | ||
issue_watch_test.go | ||
issue_watch.go | ||
issue_xref_test.go | ||
issue_xref.go | ||
issue.go | ||
label_test.go | ||
label.go | ||
main_test.go | ||
milestone_test.go | ||
milestone.go | ||
pull_list.go | ||
pull_test.go | ||
pull.go | ||
reaction_test.go | ||
reaction.go | ||
review_test.go | ||
review.go | ||
stopwatch_test.go | ||
stopwatch.go | ||
tracked_time_test.go | ||
tracked_time.go |