mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-30 01:04:25 +01:00 
			
		
		
		
	A lot of our code is repeatedly testing if individual errors are specific types of Not Exist errors. This is repetitative and unnecesary. `Unwrap() error` provides a common way of labelling an error as a NotExist error and we can/should use this. This PR has chosen to use the common `io/fs` errors e.g. `fs.ErrNotExist` for our errors. This is in some ways not completely correct as these are not filesystem errors but it seems like a reasonable thing to do and would allow us to simplify a lot of our code to `errors.Is(err, fs.ErrNotExist)` instead of `package.IsErr...NotExist(err)` I am open to suggestions to use a different base error - perhaps `models/db.ErrNotExist` if that would be felt to be better. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: delvh <dev.lh@web.de>
		
			
				
	
	
		
			98 lines
		
	
	
		
			2.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			98 lines
		
	
	
		
			2.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2015 The Gogs Authors. All rights reserved.
 | |
| // Copyright 2020 The Gitea Authors. All rights reserved.
 | |
| // Use of this source code is governed by a MIT-style
 | |
| // license that can be found in the LICENSE file.
 | |
| 
 | |
| package repo
 | |
| 
 | |
| import (
 | |
| 	"fmt"
 | |
| 	"path/filepath"
 | |
| 	"strings"
 | |
| 
 | |
| 	user_model "code.gitea.io/gitea/models/user"
 | |
| 	"code.gitea.io/gitea/modules/log"
 | |
| 	"code.gitea.io/gitea/modules/util"
 | |
| )
 | |
| 
 | |
| // ErrWikiAlreadyExist represents a "WikiAlreadyExist" kind of error.
 | |
| type ErrWikiAlreadyExist struct {
 | |
| 	Title string
 | |
| }
 | |
| 
 | |
| // IsErrWikiAlreadyExist checks if an error is an ErrWikiAlreadyExist.
 | |
| func IsErrWikiAlreadyExist(err error) bool {
 | |
| 	_, ok := err.(ErrWikiAlreadyExist)
 | |
| 	return ok
 | |
| }
 | |
| 
 | |
| func (err ErrWikiAlreadyExist) Error() string {
 | |
| 	return fmt.Sprintf("wiki page already exists [title: %s]", err.Title)
 | |
| }
 | |
| 
 | |
| func (err ErrWikiAlreadyExist) Unwrap() error {
 | |
| 	return util.ErrAlreadyExist
 | |
| }
 | |
| 
 | |
| // ErrWikiReservedName represents a reserved name error.
 | |
| type ErrWikiReservedName struct {
 | |
| 	Title string
 | |
| }
 | |
| 
 | |
| // IsErrWikiReservedName checks if an error is an ErrWikiReservedName.
 | |
| func IsErrWikiReservedName(err error) bool {
 | |
| 	_, ok := err.(ErrWikiReservedName)
 | |
| 	return ok
 | |
| }
 | |
| 
 | |
| func (err ErrWikiReservedName) Error() string {
 | |
| 	return fmt.Sprintf("wiki title is reserved: %s", err.Title)
 | |
| }
 | |
| 
 | |
| func (err ErrWikiReservedName) Unwrap() error {
 | |
| 	return util.ErrInvalidArgument
 | |
| }
 | |
| 
 | |
| // ErrWikiInvalidFileName represents an invalid wiki file name.
 | |
| type ErrWikiInvalidFileName struct {
 | |
| 	FileName string
 | |
| }
 | |
| 
 | |
| // IsErrWikiInvalidFileName checks if an error is an ErrWikiInvalidFileName.
 | |
| func IsErrWikiInvalidFileName(err error) bool {
 | |
| 	_, ok := err.(ErrWikiInvalidFileName)
 | |
| 	return ok
 | |
| }
 | |
| 
 | |
| func (err ErrWikiInvalidFileName) Error() string {
 | |
| 	return fmt.Sprintf("Invalid wiki filename: %s", err.FileName)
 | |
| }
 | |
| 
 | |
| func (err ErrWikiInvalidFileName) Unwrap() error {
 | |
| 	return util.ErrInvalidArgument
 | |
| }
 | |
| 
 | |
| // WikiCloneLink returns clone URLs of repository wiki.
 | |
| func (repo *Repository) WikiCloneLink() *CloneLink {
 | |
| 	return repo.cloneLink(true)
 | |
| }
 | |
| 
 | |
| // WikiPath returns wiki data path by given user and repository name.
 | |
| func WikiPath(userName, repoName string) string {
 | |
| 	return filepath.Join(user_model.UserPath(userName), strings.ToLower(repoName)+".wiki.git")
 | |
| }
 | |
| 
 | |
| // WikiPath returns wiki data path for given repository.
 | |
| func (repo *Repository) WikiPath() string {
 | |
| 	return WikiPath(repo.OwnerName, repo.Name)
 | |
| }
 | |
| 
 | |
| // HasWiki returns true if repository has wiki.
 | |
| func (repo *Repository) HasWiki() bool {
 | |
| 	isDir, err := util.IsDir(repo.WikiPath())
 | |
| 	if err != nil {
 | |
| 		log.Error("Unable to check if %s is a directory: %v", repo.WikiPath(), err)
 | |
| 	}
 | |
| 	return isDir
 | |
| }
 |