mirror of
https://github.com/go-gitea/gitea.git
synced 2026-07-16 22:12:07 +02:00
f69e15afe7
Addresses a batch of privately reported security issues, grouped by area: - **SSRF** - migration PR-patch/asset fetches, OAuth2 avatar & OpenID discovery, pull-mirror URL re-validation, and the outbound proxy path. - **Access-token scope** - prevent scope escalation on token creation; keep public-only tokens confined (feeds, packages, Actions listings, star/watch lists, limited/private owners). - **Access control / disclosure** - go-get default-branch leak, webhook authorization-header leak, watch clearing on private transitions, label/attachment scoping. - **Denial of service** - input bounds for npm dist-tags, Debian control files, Arch file lists, and SSH keys. ### 📌 Attention for site admins Not breaking - existing configs keep working - but two changes are worth a look: - **New SSRF protection** Outbound requests (migrations, OAuth2 avatars, OpenID discovery, pull mirrors, proxy path) are now validated against the allow/block host lists. If your instance legitimately reaches internal hosts, you may need to add them to `[security].ALLOWED_HOST_LIST` (and the relevant `ALLOW_LOCALNETWORKS` settings). - **Deprecation** `[webhook].ALLOWED_HOST_LIST` is deprecated and will be removed in a future release. Use `[security].ALLOWED_HOST_LIST` instead; the old key still works for now. --------- Co-authored-by: TheFox0x7 <thefox0x7@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Zettat123 <zettat123@gmail.com>
110 lines
2.9 KiB
Go
110 lines
2.9 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package auth
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
auth_model "gitea.dev/models/auth"
|
|
"gitea.dev/models/unittest"
|
|
"gitea.dev/modules/timeutil"
|
|
"gitea.dev/modules/util"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestCheckAuthToken(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
t.Run("Empty", func(t *testing.T) {
|
|
token, err := CheckAuthToken(t.Context(), "")
|
|
assert.NoError(t, err)
|
|
assert.Nil(t, token)
|
|
})
|
|
|
|
t.Run("InvalidFormat", func(t *testing.T) {
|
|
token, err := CheckAuthToken(t.Context(), "dummy")
|
|
assert.ErrorIs(t, err, ErrAuthTokenInvalidFormat)
|
|
assert.Nil(t, token)
|
|
})
|
|
|
|
t.Run("NotFound", func(t *testing.T) {
|
|
token, err := CheckAuthToken(t.Context(), "notexists:dummy")
|
|
assert.ErrorIs(t, err, ErrAuthTokenExpired)
|
|
assert.Nil(t, token)
|
|
})
|
|
|
|
t.Run("Expired", func(t *testing.T) {
|
|
timeutil.MockSet(time.Date(2023, 1, 1, 0, 0, 0, 0, time.UTC))
|
|
|
|
at, token, err := CreateAuthTokenForUserID(t.Context(), 2)
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, at)
|
|
assert.NotEmpty(t, token)
|
|
|
|
timeutil.MockUnset()
|
|
|
|
at2, err := CheckAuthToken(t.Context(), at.ID+":"+token)
|
|
assert.ErrorIs(t, err, ErrAuthTokenExpired)
|
|
assert.Nil(t, at2)
|
|
|
|
assert.NoError(t, auth_model.DeleteAuthTokenByID(t.Context(), at.ID))
|
|
})
|
|
|
|
t.Run("InvalidHash", func(t *testing.T) {
|
|
at, token, err := CreateAuthTokenForUserID(t.Context(), 2)
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, at)
|
|
assert.NotEmpty(t, token)
|
|
|
|
at2, err := CheckAuthToken(t.Context(), at.ID+":"+token+"dummy")
|
|
assert.ErrorIs(t, err, ErrAuthTokenInvalidHash)
|
|
assert.Nil(t, at2)
|
|
|
|
// a hash mismatch signals a compromised token, which must be revoked
|
|
_, err = auth_model.GetAuthTokenByID(t.Context(), at.ID)
|
|
assert.ErrorIs(t, err, util.ErrNotExist)
|
|
})
|
|
|
|
t.Run("Valid", func(t *testing.T) {
|
|
at, token, err := CreateAuthTokenForUserID(t.Context(), 2)
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, at)
|
|
assert.NotEmpty(t, token)
|
|
|
|
at2, err := CheckAuthToken(t.Context(), at.ID+":"+token)
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, at2)
|
|
|
|
assert.NoError(t, auth_model.DeleteAuthTokenByID(t.Context(), at.ID))
|
|
})
|
|
}
|
|
|
|
func TestRegenerateAuthToken(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
timeutil.MockSet(time.Date(2023, 1, 1, 0, 0, 0, 0, time.UTC))
|
|
defer timeutil.MockUnset()
|
|
|
|
at, token, err := CreateAuthTokenForUserID(t.Context(), 2)
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, at)
|
|
assert.NotEmpty(t, token)
|
|
|
|
timeutil.MockSet(time.Date(2023, 1, 1, 0, 0, 1, 0, time.UTC))
|
|
|
|
at2, token2, err := RegenerateAuthToken(t.Context(), at)
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, at2)
|
|
assert.NotEmpty(t, token2)
|
|
|
|
assert.Equal(t, at.ID, at2.ID)
|
|
assert.Equal(t, at.UserID, at2.UserID)
|
|
assert.NotEqual(t, token, token2)
|
|
assert.NotEqual(t, at.ExpiresUnix, at2.ExpiresUnix)
|
|
|
|
assert.NoError(t, auth_model.DeleteAuthTokenByID(t.Context(), at.ID))
|
|
}
|