mirror of
https://github.com/go-gitea/gitea.git
synced 2026-06-02 18:59:00 +02:00
d0eba5e961
Updates `github.com/urfave/cli/v3` to [v3.9.0](https://github.com/urfave/cli/releases/tag/v3.9.0) and removes the renovate pin now that [urfave/cli#2319](https://github.com/urfave/cli/pull/2319) (the `-c` help flag parsing fix) is merged. v3.9.0 prepends the default command name to the root command's args, which broke the old `Root().Args()` check in `isValidDefaultSubCommand`. It now uses the command's own `Args()`. Behavior change: `./gitea web <extra-positional-arg>` now errors with `unknown command` instead of starting the web server and ignoring the trailing arg. `web` takes no positional args, so this is stricter (and arguably more correct) input handling. The intended `./gitea bad-cmd` rejection is unchanged. --- This PR was written with the help of Claude Opus 4.7 --------- Co-authored-by: Claude (Opus 4.7) <noreply@anthropic.com> Co-authored-by: Nicolas <bircni@icloud.com>
46 lines
1.1 KiB
Go
46 lines
1.1 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"gitea.dev/models/unittest"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/urfave/cli/v3"
|
|
)
|
|
|
|
func TestMain(m *testing.M) {
|
|
unittest.MainTest(m)
|
|
}
|
|
|
|
func TestDefaultCommand(t *testing.T) {
|
|
test := func(t *testing.T, args []string, expectedRetName string, expectedRetValid bool) {
|
|
called := false
|
|
cmd := &cli.Command{
|
|
DefaultCommand: "test",
|
|
Commands: []*cli.Command{
|
|
{
|
|
Name: "test",
|
|
Action: func(ctx context.Context, command *cli.Command) error {
|
|
retName, retValid := isValidDefaultSubCommand(command)
|
|
assert.Equal(t, expectedRetName, retName)
|
|
assert.Equal(t, expectedRetValid, retValid)
|
|
called = true
|
|
return nil
|
|
},
|
|
},
|
|
},
|
|
}
|
|
assert.NoError(t, cmd.Run(t.Context(), args))
|
|
assert.True(t, called)
|
|
}
|
|
test(t, []string{"./gitea"}, "", true)
|
|
test(t, []string{"./gitea", "test"}, "", true)
|
|
test(t, []string{"./gitea", "other"}, "other", false)
|
|
test(t, []string{"./gitea", "test", "extra"}, "extra", false)
|
|
}
|