0
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-12-23 11:55:00 +01:00
gitea/templates/user
wxiaoguang 027014d7de
Fix webauthn regression and improve code (#25113)
Follow:

* #22697

There are some bugs in #22697:

* https://github.com/go-gitea/gitea/pull/22697#issuecomment-1577957966
* the webauthn failure message is never shown and causes console error
* The `document.getElementById('register-button')` and
`document.getElementById('login-button')` is wrong
    * there is no such element in code
    * it causes JS error when a browser doesn't provide webauthn
    * the end user can't see the real error message

These bugs are fixed in this PR.

Other changes:

* Use simple HTML/CSS layouts, no need to use too many `gt-` patches
* Make the webauthn page have correct "page-content" layout
* The "data-webauthn-error-msg" elements are only used to provide locale
texts, so move them into a single "gt-hidden", then no need to repeat a
lot of "gt-hidden" in code
* The `{{.CsrfTokenHtml}}`  is a no-op because there is no form
* Many `hideElem('#webauthn-error')` in code is no-op because the
`webauthn-error` already has "gt-hidden" by default
* Make the tests for "URLEncodedBase64" really test with concrete cases.


Screenshots:

* Error message when webauthn fails (before, there is no error message):

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/93cf9559-d93b-4f06-9d98-0f7032d9c65b)

</details>

* Error message when webauthn is unavailable 

<details>


![image](https://github.com/go-gitea/gitea/assets/2114189/ffc0fcd9-b93b-4418-979c-c89bb627aaf2)

</details>
2023-06-07 19:20:18 +08:00
..
auth Fix webauthn regression and improve code (#25113) 2023-06-07 19:20:18 +08:00
dashboard Fix incorrect issuel filter menu style (#25018) 2023-05-31 12:44:28 +02:00
notification Fix 500 error caused by notifications without an issue such as repo transfers (#25101) 2023-06-06 23:17:56 +08:00
overview Add Gitea Profile Readmes (#23260) 2023-05-09 05:57:24 +00:00
settings Fix webauthn regression and improve code (#25113) 2023-06-07 19:20:18 +08:00
code.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
heatmap.tmpl Improve template helper (#24417) 2023-04-29 08:02:29 -04:00
profile.tmpl Fix double border and adjust width for user profile page (#24870) 2023-05-23 17:55:51 +00:00