mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-31 18:12:20 +01:00 
			
		
		
		
	There were too many patches to the Render system, it's really difficult to make further improvements. This PR clears the legacy problems and fix TODOs. 1. Rename `RenderContext.Type` to `RenderContext.MarkupType` to clarify its usage. 2. Use `ContentMode` to replace `meta["mode"]` and `IsWiki`, to clarify the rendering behaviors. 3. Use "wiki" mode instead of "mode=gfm + wiki=true" 4. Merge `renderByType` and `renderByFile` 5. Add more comments ---- The problem of "mode=document": in many cases it is not set, so many non-comment places use comment's hard line break incorrectly
		
			
				
	
	
		
			63 lines
		
	
	
		
			1.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			63 lines
		
	
	
		
			1.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2024 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package markup
 | |
| 
 | |
| import (
 | |
| 	"code.gitea.io/gitea/modules/util"
 | |
| 
 | |
| 	"golang.org/x/net/html"
 | |
| )
 | |
| 
 | |
| func visitNodeImg(ctx *RenderContext, img *html.Node) (next *html.Node) {
 | |
| 	next = img.NextSibling
 | |
| 	for i, attr := range img.Attr {
 | |
| 		if attr.Key != "src" {
 | |
| 			continue
 | |
| 		}
 | |
| 
 | |
| 		if IsNonEmptyRelativePath(attr.Val) {
 | |
| 			attr.Val = util.URLJoin(ctx.Links.ResolveMediaLink(ctx.ContentMode == RenderContentAsWiki), attr.Val)
 | |
| 
 | |
| 			// By default, the "<img>" tag should also be clickable,
 | |
| 			// because frontend use `<img>` to paste the re-scaled image into the markdown,
 | |
| 			// so it must match the default markdown image behavior.
 | |
| 			hasParentAnchor := false
 | |
| 			for p := img.Parent; p != nil; p = p.Parent {
 | |
| 				if hasParentAnchor = p.Type == html.ElementNode && p.Data == "a"; hasParentAnchor {
 | |
| 					break
 | |
| 				}
 | |
| 			}
 | |
| 			if !hasParentAnchor {
 | |
| 				imgA := &html.Node{Type: html.ElementNode, Data: "a", Attr: []html.Attribute{
 | |
| 					{Key: "href", Val: attr.Val},
 | |
| 					{Key: "target", Val: "_blank"},
 | |
| 				}}
 | |
| 				parent := img.Parent
 | |
| 				imgNext := img.NextSibling
 | |
| 				parent.RemoveChild(img)
 | |
| 				parent.InsertBefore(imgA, imgNext)
 | |
| 				imgA.AppendChild(img)
 | |
| 			}
 | |
| 		}
 | |
| 		attr.Val = camoHandleLink(attr.Val)
 | |
| 		img.Attr[i] = attr
 | |
| 	}
 | |
| 	return next
 | |
| }
 | |
| 
 | |
| func visitNodeVideo(ctx *RenderContext, node *html.Node) (next *html.Node) {
 | |
| 	next = node.NextSibling
 | |
| 	for i, attr := range node.Attr {
 | |
| 		if attr.Key != "src" {
 | |
| 			continue
 | |
| 		}
 | |
| 		if IsNonEmptyRelativePath(attr.Val) {
 | |
| 			attr.Val = util.URLJoin(ctx.Links.ResolveMediaLink(ctx.ContentMode == RenderContentAsWiki), attr.Val)
 | |
| 		}
 | |
| 		attr.Val = camoHandleLink(attr.Val)
 | |
| 		node.Attr[i] = attr
 | |
| 	}
 | |
| 	return next
 | |
| }
 |