0
0
mirror of https://github.com/go-gitea/gitea.git synced 2025-01-19 09:06:20 +01:00
gitea/models/user
Gwyneth Morgan 360b3fd17c
Include username in email headers (#28981)
Emails from Gitea comments do not contain the username of the commenter
anywhere, only their display name, so it is not possible to verify who
made a comment from the email itself:

	From: "Alice" <email@gitea>
	X-Gitea-Sender: Alice
	X-Gitea-Recipient: Bob
	X-GitHub-Sender: Alice
	X-GitHub-Recipient: Bob

	This comment looks like it's from @alice.

The X-Gitea/X-GitHub headers also use display names, which is not very
reliable for filtering, and inconsistent with GitHub's behavior:

	X-GitHub-Sender: lunny
	X-GitHub-Recipient: gwymor

This change includes both the display name and username in the From
header, and switches the other headers from display name to username:

	From: "Alice (@fakealice)" <email@gitea>
	X-Gitea-Sender: fakealice
	X-Gitea-Recipient: bob
	X-GitHub-Sender: fakealice
	X-GitHub-Recipient: bob

	This comment looks like it's from @alice.
2024-02-03 00:41:27 +00:00
..
avatar.go
badge.go
email_address_test.go
email_address.go
error.go
external_login_user.go
follow_test.go
follow.go
list.go
main_test.go
must_change_password.go
openid_test.go
openid.go
redirect_test.go
redirect.go
search.go
setting_keys.go
setting_test.go
setting.go
user_system.go Replace -1 with GhostUserID (#27703) 2023-10-20 14:43:08 +00:00
user_test.go
user_update.go
user.go