mirror of
https://github.com/go-gitea/gitea.git
synced 2026-03-29 00:24:46 +01:00
When the email field was submitted as empty in org settings (web and API), the previous guard `if form.Email != ""` silently skipped the update, making it impossible to remove a contact email after it was set. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
77 lines
2.3 KiB
Go
77 lines
2.3 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package user
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/unittest"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestUserEmail(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
t.Run("PrimaryEmailAddress", func(t *testing.T) {
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 13})
|
|
|
|
emails, err := user_model.GetEmailAddresses(t.Context(), user.ID)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, emails, 1)
|
|
|
|
primary, err := user_model.GetPrimaryEmailAddressOfUser(t.Context(), user.ID)
|
|
assert.NoError(t, err)
|
|
assert.NotEqual(t, "primary-13@example.com", primary.Email)
|
|
assert.Equal(t, user.Email, primary.Email)
|
|
|
|
assert.NoError(t, ReplacePrimaryEmailAddress(t.Context(), user, "primary-13@example.com"))
|
|
|
|
primary, err = user_model.GetPrimaryEmailAddressOfUser(t.Context(), user.ID)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, "primary-13@example.com", primary.Email)
|
|
assert.Equal(t, user.Email, primary.Email)
|
|
|
|
emails, err = user_model.GetEmailAddresses(t.Context(), user.ID)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, emails, 1)
|
|
|
|
assert.NoError(t, ReplacePrimaryEmailAddress(t.Context(), user, "primary-13@example.com"))
|
|
})
|
|
|
|
t.Run("AddEmailAddresses", func(t *testing.T) {
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
|
|
assert.Error(t, AddEmailAddresses(t.Context(), user, []string{" invalid email "}))
|
|
|
|
emails := []string{"user1234@example.com", "user5678@example.com"}
|
|
|
|
assert.NoError(t, AddEmailAddresses(t.Context(), user, emails))
|
|
|
|
err := AddEmailAddresses(t.Context(), user, emails)
|
|
assert.Error(t, err)
|
|
assert.True(t, user_model.IsErrEmailAlreadyUsed(err))
|
|
})
|
|
|
|
t.Run("DeleteEmailAddresses", func(t *testing.T) {
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
|
|
emails := []string{"user2-2@example.com"}
|
|
|
|
err := DeleteEmailAddresses(t.Context(), user, emails)
|
|
assert.NoError(t, err)
|
|
|
|
err = DeleteEmailAddresses(t.Context(), user, emails)
|
|
assert.Error(t, err)
|
|
assert.True(t, user_model.IsErrEmailAddressNotExist(err))
|
|
|
|
emails = []string{"user2@example.com"}
|
|
|
|
err = DeleteEmailAddresses(t.Context(), user, emails)
|
|
assert.Error(t, err)
|
|
assert.True(t, user_model.IsErrPrimaryEmailCannotDelete(err))
|
|
})
|
|
}
|