0
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-12-18 21:50:01 +01:00
gitea/models
sillyguodong bfecf3bd89
Fix internal sever error when visiting a PR that bound to the deleted team (#24127)
Close: #23738

The actual cause of `500 Internal Server Error` in the issue is not what
is descirbed in the issue.

The actual cause is that after deleting team, if there is a PR which has
requested reivew from the deleted team, the comment could not match with
the deleted team by `assgin_team_id`. So the value of `.AssigneeTeam`
(see below code block) is `nil` which cause `500 error`.


1c8bc4081a/templates/repo/issue/view_content/comments.tmpl (L691-L695)

To fix this bug, there are the following problems to be resolved:

- [x] 1. ~~Stroe the name of the team in `content` column when inserting
`comment` into DB in case that we cannot get the name of team after it
is deleted. But for comments that already exist, just display "Unknown
Team"~~ Just display "Ghost Team" in the comment if the assgined team is
deleted.
- [x] 2. Delete the PR&team binding (the row of which `review_team_id =
${team_id} ` in table `review`) when deleting team.
- [x] 3.For already exist and undeleted binding rows in in table
`review`, ~~we can delete these rows when executing migrations.~~ they
do not affect the function, so won't delete them.
2023-04-19 19:50:00 -04:00
..
actions Treat PRs with agit flow as fork PRs when triggering actions. (#23884) 2023-04-06 16:57:30 -04:00
activities Localize activity heatmap (except tooltip) (#24131) 2023-04-17 14:26:01 -04:00
admin
asymkey Prefer native parser for SSH public key parsing (#23798) 2023-04-11 14:34:28 +08:00
auth Fix 500 error if there is a name conflict when edit authentication source (#23832) 2023-03-31 22:32:18 +08:00
avatars Avoid warning for system setting when start up (#23054) 2023-02-24 18:23:13 +08:00
db Allow adding new files to an empty repo (#24164) 2023-04-19 21:40:42 +08:00
dbfs Allow adding new files to an empty repo (#24164) 2023-04-19 21:40:42 +08:00
fixtures Allow adding new files to an empty repo (#24164) 2023-04-19 21:40:42 +08:00
git Fix branch protection priority (#24045) 2023-04-11 13:22:49 -04:00
issues Make more functions use ctx instead of db.DefaultContext (#24068) 2023-04-14 14:18:28 -04:00
migrations Add migration to fix external unit access mode of owner/admin team (#24117) 2023-04-15 09:52:44 -04:00
organization Add owner team permission check test (#24096) 2023-04-19 19:19:13 -04:00
packages Use ghost user if package creator does not exist (#23822) 2023-04-04 16:14:46 +08:00
perm Rename repo.GetOwner to repo.LoadOwner (#22967) 2023-02-18 20:11:03 +08:00
project Improve GetBoards and getDefaultBoard (#22981) 2023-04-09 22:07:23 +08:00
pull
repo Allow adding new files to an empty repo (#24164) 2023-04-19 21:40:42 +08:00
secret
system Avoid warning for system setting when start up (#23054) 2023-02-24 18:23:13 +08:00
unit Improve LoadUnitConfig to handle invalid or duplicate units (#23736) 2023-04-03 16:42:38 +08:00
unittest Allow adding new files to an empty repo (#24164) 2023-04-19 21:40:42 +08:00
user Allow adding new files to an empty repo (#24164) 2023-04-19 21:40:42 +08:00
webhook Add user webhooks (#21563) 2023-03-10 08:28:32 -06:00
error.go
fixture_generation.go
fixture_test.go
main_test.go Refactor the setting to make unit test easier (#22405) 2023-02-20 00:12:01 +08:00
migrate_test.go
migrate.go
org_team_test.go
org_team.go Fix internal sever error when visiting a PR that bound to the deleted team (#24127) 2023-04-19 19:50:00 -04:00
org_test.go
org.go
repo_collaboration_test.go Rename repo.GetOwner to repo.LoadOwner (#22967) 2023-02-18 20:11:03 +08:00
repo_collaboration.go
repo_test.go
repo_transfer_test.go
repo_transfer.go
repo.go Avoid warning for system setting when start up (#23054) 2023-02-24 18:23:13 +08:00