mirror of
https://github.com/go-gitea/gitea.git
synced 2024-12-23 16:15:51 +01:00
846f618716
## Solves Currently for rules to re-order them you have to alter the creation date. so you basicly have to delete and recreate them in the right order. This is more than just inconvinient ... ## Solution Add a new col for prioritization ## Demo WebUI Video https://github.com/user-attachments/assets/92182a31-9705-4ac5-b6e3-9bb74108cbd1 --- *Sponsored by Kithara Software GmbH*
140 lines
3.0 KiB
Go
140 lines
3.0 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package git
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestBranchRuleMatchPriority(t *testing.T) {
|
|
kases := []struct {
|
|
Rules []string
|
|
BranchName string
|
|
ExpectedMatchIdx int
|
|
}{
|
|
{
|
|
Rules: []string{"release/*", "release/v1.17"},
|
|
BranchName: "release/v1.17",
|
|
ExpectedMatchIdx: 1,
|
|
},
|
|
{
|
|
Rules: []string{"release/v1.17", "release/*"},
|
|
BranchName: "release/v1.17",
|
|
ExpectedMatchIdx: 0,
|
|
},
|
|
{
|
|
Rules: []string{"release/**/v1.17", "release/test/v1.17"},
|
|
BranchName: "release/test/v1.17",
|
|
ExpectedMatchIdx: 1,
|
|
},
|
|
{
|
|
Rules: []string{"release/test/v1.17", "release/**/v1.17"},
|
|
BranchName: "release/test/v1.17",
|
|
ExpectedMatchIdx: 0,
|
|
},
|
|
{
|
|
Rules: []string{"release/**", "release/v1.0.0"},
|
|
BranchName: "release/v1.0.0",
|
|
ExpectedMatchIdx: 1,
|
|
},
|
|
{
|
|
Rules: []string{"release/v1.0.0", "release/**"},
|
|
BranchName: "release/v1.0.0",
|
|
ExpectedMatchIdx: 0,
|
|
},
|
|
{
|
|
Rules: []string{"release/**", "release/v1.0.0"},
|
|
BranchName: "release/v2.0.0",
|
|
ExpectedMatchIdx: 0,
|
|
},
|
|
{
|
|
Rules: []string{"release/*", "release/v1.0.0"},
|
|
BranchName: "release/1/v2.0.0",
|
|
ExpectedMatchIdx: -1,
|
|
},
|
|
}
|
|
|
|
for _, kase := range kases {
|
|
var pbs ProtectedBranchRules
|
|
for _, rule := range kase.Rules {
|
|
pbs = append(pbs, &ProtectedBranch{RuleName: rule})
|
|
}
|
|
pbs.sort()
|
|
matchedPB := pbs.GetFirstMatched(kase.BranchName)
|
|
if matchedPB == nil {
|
|
if kase.ExpectedMatchIdx >= 0 {
|
|
assert.Error(t, fmt.Errorf("no matched rules but expected %s[%d]", kase.Rules[kase.ExpectedMatchIdx], kase.ExpectedMatchIdx))
|
|
}
|
|
} else {
|
|
assert.EqualValues(t, kase.Rules[kase.ExpectedMatchIdx], matchedPB.RuleName)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestBranchRuleSortLegacy(t *testing.T) {
|
|
in := []*ProtectedBranch{{
|
|
RuleName: "b",
|
|
CreatedUnix: 1,
|
|
}, {
|
|
RuleName: "b/*",
|
|
CreatedUnix: 3,
|
|
}, {
|
|
RuleName: "a/*",
|
|
CreatedUnix: 2,
|
|
}, {
|
|
RuleName: "c",
|
|
CreatedUnix: 0,
|
|
}, {
|
|
RuleName: "a",
|
|
CreatedUnix: 4,
|
|
}}
|
|
expect := []string{"c", "b", "a", "a/*", "b/*"}
|
|
|
|
pbr := ProtectedBranchRules(in)
|
|
pbr.sort()
|
|
|
|
var got []string
|
|
for i := range pbr {
|
|
got = append(got, pbr[i].RuleName)
|
|
}
|
|
assert.Equal(t, expect, got)
|
|
}
|
|
|
|
func TestBranchRuleSortPriority(t *testing.T) {
|
|
in := []*ProtectedBranch{{
|
|
RuleName: "b",
|
|
CreatedUnix: 1,
|
|
Priority: 4,
|
|
}, {
|
|
RuleName: "b/*",
|
|
CreatedUnix: 3,
|
|
Priority: 2,
|
|
}, {
|
|
RuleName: "a/*",
|
|
CreatedUnix: 2,
|
|
Priority: 1,
|
|
}, {
|
|
RuleName: "c",
|
|
CreatedUnix: 0,
|
|
Priority: 0,
|
|
}, {
|
|
RuleName: "a",
|
|
CreatedUnix: 4,
|
|
Priority: 3,
|
|
}}
|
|
expect := []string{"c", "a/*", "b/*", "a", "b"}
|
|
|
|
pbr := ProtectedBranchRules(in)
|
|
pbr.sort()
|
|
|
|
var got []string
|
|
for i := range pbr {
|
|
got = append(got, pbr[i].RuleName)
|
|
}
|
|
assert.Equal(t, expect, got)
|
|
}
|