Ember 022a77fe3e fix(api): address review feedback on project board API ...

Three issues raised by @lunny in review of #36008 are addressed:

1. Duplicate permission checks removed
   The /projects route group is already wrapped with reqRepoReader and
   reqRepoWriter in api.go. The inline CanRead/CanWrite checks at the
   top of all 10 handlers were unreachable dead code.

2. AddOrUpdateIssueToColumn replaced with IssueAssignOrRemoveProject
   The custom function introduced in #36008 was missing a db.WithTx
   transaction wrapper, the CommentTypeProject audit comment written by
   the UI, and the CanBeAccessedByOwnerRepo cross-repo ownership guard.
   AddIssueToProjectColumn now delegates to the existing
   IssueAssignOrRemoveProject which provides all three.

3. ListProjectColumns pagination implemented correctly
   Added CountColumns and GetColumnsPaginated (using
   db.SetSessionPagination) to the project model. The handler uses
   utils.GetListOptions and sets X-Total-Count via
   ctx.SetTotalCountHeader per API contribution guidelines.
   Integration tests cover full list, page 1, page 2, and 404.

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>

2026-03-04 09:56:05 -05:00

..

column_test.go

fix(api): address review feedback on project board API

2026-03-04 09:56:05 -05:00

column.go

fix(api): address review feedback on project board API

2026-03-04 09:56:05 -05:00

issue.go

Enable addtional linters (#34085)

2025-04-01 10:14:01 +00:00

main_test.go

…

project_test.go

Remove incorrect "db.DefaultContext" usages (#35366)

2025-08-28 03:52:43 +00:00

project.go

Fix permission check on org project operations (#36318)

2026-01-14 17:29:33 +00:00

template.go

Rename project board -> column to make the UI less confusing (#30170)

2024-05-27 08:59:54 +00:00