mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-11-04 08:34:30 +01:00 
			
		
		
		
	* Add missing `X-Total-Count` and fix some related bugs
Adds `X-Total-Count` header to APIs that return a list but doesn't have it yet.
Fixed bugs:
* not returned after reporting error (39eb82446c/routers/api/v1/user/star.go (L70))
* crash with index out of bounds, API issue/issueSubscriptions
I also found various endpoints that return lists but do not apply/support pagination yet:
```
/repos/{owner}/{repo}/issues/{index}/labels
/repos/{owner}/{repo}/issues/comments/{id}/reactions
/repos/{owner}/{repo}/branch_protections
/repos/{owner}/{repo}/contents
/repos/{owner}/{repo}/hooks/git
/repos/{owner}/{repo}/issue_templates
/repos/{owner}/{repo}/releases/{id}/assets
/repos/{owner}/{repo}/reviewers
/repos/{owner}/{repo}/teams
/user/emails
/users/{username}/heatmap
```
If this is not expected, an new issue should be opened.
Closes #13043
* fmt
* Update routers/api/v1/repo/issue_subscription.go
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* Use FindAndCount
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
		
	
			
		
			
				
	
	
		
			40 lines
		
	
	
		
			1.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			40 lines
		
	
	
		
			1.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Copyright 2021 The Gogs Authors. All rights reserved.
 | 
						|
// Use of this source code is governed by a MIT-style
 | 
						|
// license that can be found in the LICENSE file.
 | 
						|
 | 
						|
package mailer
 | 
						|
 | 
						|
import (
 | 
						|
	"testing"
 | 
						|
	"time"
 | 
						|
 | 
						|
	"code.gitea.io/gitea/modules/setting"
 | 
						|
 | 
						|
	"github.com/stretchr/testify/assert"
 | 
						|
)
 | 
						|
 | 
						|
func TestGenerateMessageID(t *testing.T) {
 | 
						|
	var mailService = setting.Mailer{
 | 
						|
		From: "test@gitea.com",
 | 
						|
	}
 | 
						|
 | 
						|
	setting.MailService = &mailService
 | 
						|
	setting.Domain = "localhost"
 | 
						|
 | 
						|
	date := time.Date(2000, 01, 02, 03, 04, 05, 06, time.UTC)
 | 
						|
	m := NewMessageFrom(nil, "display-name", "from-address", "subject", "body")
 | 
						|
	m.Date = date
 | 
						|
	gm := m.ToMessage()
 | 
						|
	assert.Equal(t, "<autogen-946782245000-41e8fc54a8ad3a3f@localhost>", gm.GetHeader("Message-ID")[0])
 | 
						|
 | 
						|
	m = NewMessageFrom([]string{"a@b.com"}, "display-name", "from-address", "subject", "body")
 | 
						|
	m.Date = date
 | 
						|
	gm = m.ToMessage()
 | 
						|
	assert.Equal(t, "<autogen-946782245000-cc88ce3cfe9bd04f@localhost>", gm.GetHeader("Message-ID")[0])
 | 
						|
 | 
						|
	m = NewMessageFrom([]string{"a@b.com"}, "display-name", "from-address", "subject", "body")
 | 
						|
	m.SetHeader("Message-ID", "<msg-d@domain.com>")
 | 
						|
	gm = m.ToMessage()
 | 
						|
	assert.Equal(t, "<msg-d@domain.com>", gm.GetHeader("Message-ID")[0])
 | 
						|
}
 |