0
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-12-23 07:34:56 +01:00
gitea/cmd
wxiaoguang 580e21dd2e
Refactor LFS SSH and internal routers ()
Gitea instance keeps reporting a lot of errors like "LFS SSH transfer connection denied, pure SSH protocol is disabled". When starting debugging the problem, there are more problems found. Try to address most of them:

* avoid unnecessary server side error logs (change `fail()` to not log them)
* figure out the broken tests/user2/lfs.git (added comments)
* avoid `migratePushMirrors` failure when a repository doesn't exist (ignore them)
* avoid "Authorization" (internal&lfs) header conflicts, remove the tricky "swapAuth" and use "X-Gitea-Internal-Auth"
* make internal token comparing constant time (it wasn't a serous problem because in a real world it's nearly impossible to timing-attack the token, but good to fix and backport)
* avoid duplicate routers (introduce AddOwnerRepoGitLFSRoutes)
* avoid "internal (private)" routes using session/web context (they should use private context)
* fix incorrect "path" usages (use "filepath")
* fix incorrect mocked route point handling (need to check func nil correctly)
* split some tests from "git general tests" to "git misc tests" (to keep "git_general_test.go" simple)

Still no correct result for Git LFS SSH tests. So the code is kept there
(`tests/integration/git_lfs_ssh_test.go`) and a FIXME explains the details.
2024-11-12 02:38:22 +00:00
..
actions.go Return responseText instead of string in some functions () 2024-01-19 10:45:23 +08:00
admin_auth_ldap_test.go Penultimate round of db.DefaultContext refactor () 2023-10-11 04:24:07 +00:00
admin_auth_ldap.go chore: fix some function names in comment () 2024-10-22 08:41:05 +08:00
admin_auth_oauth.go chore: use errors.New to replace fmt.Errorf with no parameters will much better () 2024-04-21 19:44:03 +00:00
admin_auth_stmp.go chore: use errors.New to replace fmt.Errorf with no parameters will much better () 2024-04-21 19:44:03 +00:00
admin_auth.go chore: use errors.New to replace fmt.Errorf with no parameters will much better () 2024-04-21 19:44:03 +00:00
admin_regenerate.go Move some asymkey functions to service layer () 2024-03-04 08:57:39 +00:00
admin_user_change_password.go Add some tests to clarify the "must-change-password" behavior () 2024-04-27 12:23:37 +00:00
admin_user_create_test.go Add some tests to clarify the "must-change-password" behavior () 2024-04-27 12:23:37 +00:00
admin_user_create.go Save initial signup information for users to aid in spam prevention () 2024-09-09 17:05:16 -04:00
admin_user_delete.go chore: use errors.New to replace fmt.Errorf with no parameters will much better () 2024-04-21 19:44:03 +00:00
admin_user_generate_access_token.go chore: use errors.New to replace fmt.Errorf with no parameters will much better () 2024-04-21 19:44:03 +00:00
admin_user_list.go Reduce usage of db.DefaultContext () 2023-09-14 17:09:32 +00:00
admin_user_must_change_password.go Refactor to use urfave/cli/v2 () 2023-07-21 17:28:19 +08:00
admin_user.go Refactor to use urfave/cli/v2 () 2023-07-21 17:28:19 +08:00
admin.go Simplify how git repositories are opened () 2024-01-27 21:09:51 +01:00
cert.go Expanded minimum RSA Keylength to 3072 () 2023-08-28 00:53:16 +00:00
cmd.go Refactor to use urfave/cli/v2 () 2023-07-21 17:28:19 +08:00
docs.go Refactor to use urfave/cli/v2 () 2023-07-21 17:28:19 +08:00
doctor_convert.go Recommend/convert to use case-sensitive collation for MySQL/MSSQL () 2024-01-10 11:03:23 +00:00
doctor_test.go Move doctor package from modules to services () 2024-01-20 10:07:31 +08:00
doctor.go Move doctor package from modules to services () 2024-01-20 10:07:31 +08:00
dump_repo.go Refactor to use urfave/cli/v2 () 2023-07-21 17:28:19 +08:00
dump.go Add --skip-db option to dump command () 2024-04-21 23:32:12 +02:00
embedded.go chore: use errors.New to replace fmt.Errorf with no parameters will much better () 2024-04-21 19:44:03 +00:00
generate.go Refactor JWT secret generating & decoding code () 2024-02-16 15:18:30 +00:00
hook_test.go Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" () 2023-03-29 14:32:26 +08:00
hook.go Make git push options accept short name () 2024-10-12 05:42:10 +00:00
keys.go Refactor cmd setup and remove deadcode () 2024-02-22 07:04:30 +00:00
mailer.go Return responseText instead of string in some functions () 2024-01-19 10:45:23 +08:00
main_test.go Add some tests to clarify the "must-change-password" behavior () 2024-04-27 12:23:37 +00:00
main.go Add some tests to clarify the "must-change-password" behavior () 2024-04-27 12:23:37 +00:00
manager_logging.go chore: use errors.New to replace fmt.Errorf with no parameters will much better () 2024-04-21 19:44:03 +00:00
manager.go Refactor to use urfave/cli/v2 () 2023-07-21 17:28:19 +08:00
migrate_storage_test.go Another round of db.DefaultContext refactor () 2023-09-25 13:17:37 +00:00
migrate_storage.go fix: allow actions artifacts storage migration to complete succesfully () 2024-06-05 12:00:56 +08:00
migrate.go Refactor to use urfave/cli/v2 () 2023-07-21 17:28:19 +08:00
restore_repo.go Refactor to use urfave/cli/v2 () 2023-07-21 17:28:19 +08:00
serv.go Refactor LFS SSH and internal routers () 2024-11-12 02:38:22 +00:00
web_acme.go Implement FSFE REUSE for golang files () 2022-11-27 18:20:29 +00:00
web_graceful.go Implement FSFE REUSE for golang files () 2022-11-27 18:20:29 +00:00
web_https.go Implement FSFE REUSE for golang files () 2022-11-27 18:20:29 +00:00
web.go Clean up log messages () 2024-04-07 19:17:06 +08:00