mirror of
https://github.com/go-gitea/gitea.git
synced 2024-12-22 05:45:10 +01:00
fbe6d9dc6b
Resolve #31492 The response time for the Pull Requests API has improved significantly, dropping from over `2000ms` to about `350ms` on my local machine. It's about `6` times faster. A key area for further optimization lies in batch-fetching data for `apiPullRequest.ChangedFiles, apiPullRequest.Additions, and apiPullRequest.Deletions`. Tests `TestAPIViewPulls` does exist and new tests added. - This PR also fixes some bugs in `GetDiff` functions. - This PR also fixes data inconsistent in test data. For a pull request, the head branch's reference should be equal to the reference in `pull/xxx/head`.
46 lines
1.3 KiB
Go
46 lines
1.3 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
issues_model "code.gitea.io/gitea/models/issues"
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
api "code.gitea.io/gitea/modules/structs"
|
|
"code.gitea.io/gitea/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestAPIPullCommits(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
pr := unittest.AssertExistsAndLoadBean(t, &issues_model.PullRequest{ID: 2})
|
|
assert.NoError(t, pr.LoadIssue(db.DefaultContext))
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: pr.HeadRepoID})
|
|
|
|
req := NewRequestf(t, http.MethodGet, "/api/v1/repos/%s/%s/pulls/%d/commits", repo.OwnerName, repo.Name, pr.Index)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
var commits []*api.Commit
|
|
DecodeJSON(t, resp, &commits)
|
|
|
|
if !assert.Len(t, commits, 2) {
|
|
return
|
|
}
|
|
|
|
assert.Equal(t, "985f0301dba5e7b34be866819cd15ad3d8f508ee", commits[0].SHA)
|
|
assert.Equal(t, "5c050d3b6d2db231ab1f64e324f1b6b9a0b181c2", commits[1].SHA)
|
|
|
|
assert.NotEmpty(t, commits[0].Files)
|
|
assert.NotEmpty(t, commits[1].Files)
|
|
assert.NotNil(t, commits[0].RepoCommit.Verification)
|
|
assert.NotNil(t, commits[1].RepoCommit.Verification)
|
|
}
|
|
|
|
// TODO add tests for already merged PR and closed PR
|