Mirrors/gitea
0
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2024-11-28 04:08:25 +01:00
Code Issues Activity
cf2d332443
gitea/models/asymkey
History
Giteabot b140f647fc
Remove "dsa-1024" testcases from Test_SSHParsePublicKey and Test_calcFingerprint (#31905) (#31914) 
Backport #31905 by @s4uliu5

DSA is considered inherently insecure and is already disabled/removed in
OpenSSH 9.8.

Therefore "dsa-1024" tescases are failing.

```
--- FAIL: Test_calcFingerprint (0.02s)
    --- FAIL: Test_calcFingerprint/dsa-1024 (0.00s)
        --- FAIL: Test_calcFingerprint/dsa-1024/SSHKeygen (0.00s)
            ssh_key_test.go:196:
                        Error Trace:    /src/gitea/models/asymkey/ssh_key_test.go:196
                        Error:          Received unexpected error:
                                        Unable to verify key content [result: /tmp/gitea_keytest1239408114 is not a public key file.
                                        ]
                        Test:           Test_calcFingerprint/dsa-1024/SSHKeygen
            ssh_key_test.go:197:
                        Error Trace:    /src/gitea/models/asymkey/ssh_key_test.go:197
                        Error:          Not equal:
                                        expected: "SHA256:fSIHQlpKMDsGPVAXI8BPYfRp+e2sfvSt1sMrPsFiXrc"
                                        actual  : ""

                                        Diff:
                                        --- Expected
                                        +++ Actual
                                        @@ -1 +1 @@
                                        -SHA256:fSIHQlpKMDsGPVAXI8BPYfRp+e2sfvSt1sMrPsFiXrc
                                        +
                        Test:           Test_calcFingerprint/dsa-1024/SSHKeygen
FAIL
```

Fix #31624

Co-authored-by: Saulius Gurklys <s4uliu5@gmail.com>
2024-08-25 20:39:00 +08:00
..
error.go
gpg_key_add.go
gpg_key_commit_verification.go Enable more revive linter rules (#30608) 2024-04-22 11:48:42 +00:00
gpg_key_common.go Fix missing 0 prefix of GPG key id (#30245) 2024-04-02 17:50:57 +02:00
gpg_key_import.go
gpg_key_list.go Move more functions to db.Find (#28419) 2024-01-15 02:19:25 +00:00
gpg_key_test.go Fix missing 0 prefix of GPG key id (#30245) 2024-04-02 17:50:57 +02:00
gpg_key_verify.go Fix GPG subkey verify (#30193) 2024-03-31 02:35:19 +00:00
gpg_key.go Move more functions to db.Find (#28419) 2024-01-15 02:19:25 +00:00
main_test.go
ssh_key_authorized_keys.go Fix some pending problems (#29985) 2024-03-22 19:17:30 +08:00
ssh_key_commit_verification.go
ssh_key_deploy.go
ssh_key_fingerprint.go Clean up log messages (#30313) 2024-04-07 19:17:06 +08:00
ssh_key_parse.go
ssh_key_principals.go Move some asymkey functions to service layer (#28894) 2024-03-04 08:57:39 +00:00
ssh_key_test.go Remove "dsa-1024" testcases from Test_SSHParsePublicKey and Test_calcFingerprint (#31905) (#31914) 2024-08-25 20:39:00 +08:00
ssh_key_verify.go
ssh_key.go Fix panic of ssh public key page after deletion of auth source (#31829) (#31836) 2024-08-16 01:50:57 +08:00