mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-10-31 07:21:36 +01:00 
			
		
		
		
	From testing, I found that issue posters and users with repository write access are able to edit attachment names in a way that circumvents the instance-level file extension restrictions using the edit attachment APIs. This snapshot adds checks for these endpoints.
		
			
				
	
	
		
			62 lines
		
	
	
		
			1.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			62 lines
		
	
	
		
			1.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2021 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package attachment
 | |
| 
 | |
| import (
 | |
| 	"bytes"
 | |
| 	"context"
 | |
| 	"fmt"
 | |
| 	"io"
 | |
| 
 | |
| 	"code.gitea.io/gitea/models/db"
 | |
| 	repo_model "code.gitea.io/gitea/models/repo"
 | |
| 	"code.gitea.io/gitea/modules/storage"
 | |
| 	"code.gitea.io/gitea/modules/util"
 | |
| 	"code.gitea.io/gitea/services/context/upload"
 | |
| 
 | |
| 	"github.com/google/uuid"
 | |
| )
 | |
| 
 | |
| // NewAttachment creates a new attachment object, but do not verify.
 | |
| func NewAttachment(ctx context.Context, attach *repo_model.Attachment, file io.Reader, size int64) (*repo_model.Attachment, error) {
 | |
| 	if attach.RepoID == 0 {
 | |
| 		return nil, fmt.Errorf("attachment %s should belong to a repository", attach.Name)
 | |
| 	}
 | |
| 
 | |
| 	err := db.WithTx(ctx, func(ctx context.Context) error {
 | |
| 		attach.UUID = uuid.New().String()
 | |
| 		size, err := storage.Attachments.Save(attach.RelativePath(), file, size)
 | |
| 		if err != nil {
 | |
| 			return fmt.Errorf("Create: %w", err)
 | |
| 		}
 | |
| 		attach.Size = size
 | |
| 
 | |
| 		return db.Insert(ctx, attach)
 | |
| 	})
 | |
| 
 | |
| 	return attach, err
 | |
| }
 | |
| 
 | |
| // UploadAttachment upload new attachment into storage and update database
 | |
| func UploadAttachment(ctx context.Context, file io.Reader, allowedTypes string, fileSize int64, attach *repo_model.Attachment) (*repo_model.Attachment, error) {
 | |
| 	buf := make([]byte, 1024)
 | |
| 	n, _ := util.ReadAtMost(file, buf)
 | |
| 	buf = buf[:n]
 | |
| 
 | |
| 	if err := upload.Verify(buf, attach.Name, allowedTypes); err != nil {
 | |
| 		return nil, err
 | |
| 	}
 | |
| 
 | |
| 	return NewAttachment(ctx, attach, io.MultiReader(bytes.NewReader(buf), file), fileSize)
 | |
| }
 | |
| 
 | |
| // UpdateAttachment updates an attachment, verifying that its name is among the allowed types.
 | |
| func UpdateAttachment(ctx context.Context, allowedTypes string, attach *repo_model.Attachment) error {
 | |
| 	if err := upload.Verify(nil, attach.Name, allowedTypes); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	return repo_model.UpdateAttachment(ctx, attach)
 | |
| }
 |