mirror of
https://github.com/go-gitea/gitea.git
synced 2024-12-27 19:53:52 +01:00
b573512312
The "primary button" is used at many places, but sometimes they might conflict (due to button switch, hidden panel, dropdown menu, etc). Sometimes we could add a special CSS class for the buttons, but sometimes not (see the comment of QuickSubmit) This PR introduces `querySingleVisibleElem` to help to get the correct primary button (the only visible one), and prevent from querying the wrong buttons. Fix #32437 --------- Co-authored-by: silverwind <me@silverwind.io>
26 lines
1.1 KiB
TypeScript
26 lines
1.1 KiB
TypeScript
import {querySingleVisibleElem} from '../../utils/dom.ts';
|
|
|
|
export function handleGlobalEnterQuickSubmit(target) {
|
|
let form = target.closest('form');
|
|
if (form) {
|
|
if (!form.checkValidity()) {
|
|
form.reportValidity();
|
|
} else {
|
|
// here use the event to trigger the submit event (instead of calling `submit()` method directly)
|
|
// otherwise the `areYouSure` handler won't be executed, then there will be an annoying "confirm to leave" dialog
|
|
form.dispatchEvent(new SubmitEvent('submit', {bubbles: true, cancelable: true}));
|
|
}
|
|
return true;
|
|
}
|
|
form = target.closest('.ui.form');
|
|
if (form) {
|
|
// A form should only have at most one "primary" button to do quick-submit.
|
|
// Here we don't use a special class to mark the primary button,
|
|
// because there could be a lot of forms with a primary button, the quick submit should work out-of-box,
|
|
// but not keeps asking developers to add that special class again and again (it could be forgotten easily)
|
|
querySingleVisibleElem<HTMLButtonElement>(form, '.ui.primary.button')?.click();
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|