mirror of
https://github.com/go-gitea/gitea.git
synced 2026-04-04 01:24:56 +02:00
Three issues raised by @lunny in review of #36008 are addressed: 1. Duplicate permission checks removed The /projects route group is already wrapped with reqRepoReader and reqRepoWriter in api.go. The inline CanRead/CanWrite checks at the top of all 10 handlers were unreachable dead code. 2. AddOrUpdateIssueToColumn replaced with IssueAssignOrRemoveProject The custom function introduced in #36008 was missing a db.WithTx transaction wrapper, the CommentTypeProject audit comment written by the UI, and the CanBeAccessedByOwnerRepo cross-repo ownership guard. AddIssueToProjectColumn now delegates to the existing IssueAssignOrRemoveProject which provides all three. 3. ListProjectColumns pagination implemented correctly Added CountColumns and GetColumnsPaginated (using db.SetSessionPagination) to the project model. The handler uses utils.GetListOptions and sets X-Total-Count via ctx.SetTotalCountHeader per API contribution guidelines. Integration tests cover full list, page 1, page 2, and 404. Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
163 lines
4.8 KiB
Go
163 lines
4.8 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package project
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestGetDefaultColumn(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
projectWithoutDefault, err := GetProjectByID(t.Context(), 5)
|
|
assert.NoError(t, err)
|
|
|
|
// check if default column was added
|
|
column, err := projectWithoutDefault.MustDefaultColumn(t.Context())
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, int64(5), column.ProjectID)
|
|
assert.Equal(t, "Done", column.Title)
|
|
|
|
projectWithMultipleDefaults, err := GetProjectByID(t.Context(), 6)
|
|
assert.NoError(t, err)
|
|
|
|
// check if multiple defaults were removed
|
|
column, err = projectWithMultipleDefaults.MustDefaultColumn(t.Context())
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, int64(6), column.ProjectID)
|
|
assert.Equal(t, int64(9), column.ID) // there are 2 default columns in the test data, use the latest one
|
|
|
|
// set 8 as default column
|
|
assert.NoError(t, SetDefaultColumn(t.Context(), column.ProjectID, 8))
|
|
|
|
// then 9 will become a non-default column
|
|
column, err = GetColumn(t.Context(), 9)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, int64(6), column.ProjectID)
|
|
assert.False(t, column.Default)
|
|
}
|
|
|
|
func Test_moveIssuesToAnotherColumn(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
column1 := unittest.AssertExistsAndLoadBean(t, &Column{ID: 1, ProjectID: 1})
|
|
|
|
issues, err := column1.GetIssues(t.Context())
|
|
assert.NoError(t, err)
|
|
assert.Len(t, issues, 1)
|
|
assert.EqualValues(t, 1, issues[0].ID)
|
|
|
|
column2 := unittest.AssertExistsAndLoadBean(t, &Column{ID: 2, ProjectID: 1})
|
|
issues, err = column2.GetIssues(t.Context())
|
|
assert.NoError(t, err)
|
|
assert.Len(t, issues, 1)
|
|
assert.EqualValues(t, 3, issues[0].ID)
|
|
|
|
err = column1.moveIssuesToAnotherColumn(t.Context(), column2)
|
|
assert.NoError(t, err)
|
|
|
|
issues, err = column1.GetIssues(t.Context())
|
|
assert.NoError(t, err)
|
|
assert.Empty(t, issues)
|
|
|
|
issues, err = column2.GetIssues(t.Context())
|
|
assert.NoError(t, err)
|
|
assert.Len(t, issues, 2)
|
|
assert.EqualValues(t, 3, issues[0].ID)
|
|
assert.EqualValues(t, 0, issues[0].Sorting)
|
|
assert.EqualValues(t, 1, issues[1].ID)
|
|
assert.EqualValues(t, 1, issues[1].Sorting)
|
|
}
|
|
|
|
func Test_MoveColumnsOnProject(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
project1 := unittest.AssertExistsAndLoadBean(t, &Project{ID: 1})
|
|
columns, err := project1.GetColumns(t.Context())
|
|
assert.NoError(t, err)
|
|
assert.Len(t, columns, 3)
|
|
assert.EqualValues(t, 0, columns[0].Sorting) // even if there is no default sorting, the code should also work
|
|
assert.EqualValues(t, 0, columns[1].Sorting)
|
|
assert.EqualValues(t, 0, columns[2].Sorting)
|
|
|
|
err = MoveColumnsOnProject(t.Context(), project1, map[int64]int64{
|
|
0: columns[1].ID,
|
|
1: columns[2].ID,
|
|
2: columns[0].ID,
|
|
})
|
|
assert.NoError(t, err)
|
|
|
|
columnsAfter, err := project1.GetColumns(t.Context())
|
|
assert.NoError(t, err)
|
|
assert.Len(t, columnsAfter, 3)
|
|
assert.Equal(t, columns[1].ID, columnsAfter[0].ID)
|
|
assert.Equal(t, columns[2].ID, columnsAfter[1].ID)
|
|
assert.Equal(t, columns[0].ID, columnsAfter[2].ID)
|
|
}
|
|
|
|
func Test_NewColumn(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
project1 := unittest.AssertExistsAndLoadBean(t, &Project{ID: 1})
|
|
columns, err := project1.GetColumns(t.Context())
|
|
assert.NoError(t, err)
|
|
assert.Len(t, columns, 3)
|
|
|
|
for i := range maxProjectColumns - 3 {
|
|
err := NewColumn(t.Context(), &Column{
|
|
Title: fmt.Sprintf("column-%d", i+4),
|
|
ProjectID: project1.ID,
|
|
})
|
|
assert.NoError(t, err)
|
|
}
|
|
err = NewColumn(t.Context(), &Column{
|
|
Title: "column-21",
|
|
ProjectID: project1.ID,
|
|
})
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), "maximum number of columns reached")
|
|
}
|
|
|
|
func TestCountColumns(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
project, err := GetProjectByID(t.Context(), 1)
|
|
assert.NoError(t, err)
|
|
|
|
count, err := project.CountColumns(t.Context())
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 3, count)
|
|
}
|
|
|
|
func TestGetColumnsPaginated(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
project, err := GetProjectByID(t.Context(), 1)
|
|
assert.NoError(t, err)
|
|
|
|
// Page 1, limit 2 — returns first 2 columns
|
|
page1, err := project.GetColumnsPaginated(t.Context(), db.ListOptions{Page: 1, PageSize: 2})
|
|
assert.NoError(t, err)
|
|
assert.Len(t, page1, 2)
|
|
|
|
// Page 2, limit 2 — returns remaining column
|
|
page2, err := project.GetColumnsPaginated(t.Context(), db.ListOptions{Page: 2, PageSize: 2})
|
|
assert.NoError(t, err)
|
|
assert.Len(t, page2, 1)
|
|
|
|
// Page 1 and page 2 together cover all columns with no overlap
|
|
allIDs := make(map[int64]bool)
|
|
for _, c := range append(page1, page2...) {
|
|
assert.False(t, allIDs[c.ID], "duplicate column ID %d across pages", c.ID)
|
|
allIDs[c.ID] = true
|
|
}
|
|
assert.Len(t, allIDs, 3)
|
|
}
|