mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-11-04 08:34:30 +01:00 
			
		
		
		
	`models` does far too much. In particular it handles all `UserSignin`. It shouldn't be responsible for calling LDAP, SMTP or PAM for signing in. Therefore we should move this code out of `models`. This code has to depend on `models` - therefore it belongs in `services`. There is a package in `services` called `auth` and clearly this functionality belongs in there. Plan: - [x] Change `auth.Auth` to `auth.Method` - as they represent methods of authentication. - [x] Move `models.UserSignIn` into `auth` - [x] Move `models.ExternalUserLogin` - [x] Move most of the `LoginVia*` methods to `auth` or subpackages - [x] Move Resynchronize functionality to `auth` - Involved some restructuring of `models/ssh_key.go` to reduce the size of this massive file and simplify its files. - [x] Move the rest of the LDAP functionality in to the ldap subpackage - [x] Re-factor the login sources to express an interfaces `auth.Source`? - I've done this through some smaller interfaces Authenticator and Synchronizable - which would allow us to extend things in future - [x] Now LDAP is out of models - need to think about modules/auth/ldap and I think all of that functionality might just be moveable - [x] Similarly a lot Oauth2 functionality need not be in models too and should be moved to services/auth/source/oauth2 - [x] modules/auth/oauth2/oauth2.go uses xorm... This is naughty - probably need to move this into models. - [x] models/oauth2.go - mostly should be in modules/auth/oauth2 or services/auth/source/oauth2 - [x] More simplifications of login_source.go may need to be done - Allow wiring in of notify registration - *this can now easily be done - but I think we should do it in another PR* - see #16178 - More refactors...? - OpenID should probably become an auth Method but I think that can be left for another PR - Methods should also probably be cleaned up - again another PR I think. - SSPI still needs more refactors.* Rename auth.Auth auth.Method * Restructure ssh_key.go - move functions from models/user.go that relate to ssh_key to ssh_key - split ssh_key.go to try create clearer function domains for allow for future refactors here. Signed-off-by: Andrew Thornton <art27@cantab.net>
		
			
				
	
	
		
			117 lines
		
	
	
		
			3.6 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			117 lines
		
	
	
		
			3.6 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Copyright 2014 The Gogs Authors. All rights reserved.
 | 
						|
// Copyright 2019 The Gitea Authors. All rights reserved.
 | 
						|
// Use of this source code is governed by a MIT-style
 | 
						|
// license that can be found in the LICENSE file.
 | 
						|
 | 
						|
package auth
 | 
						|
 | 
						|
import (
 | 
						|
	"net/http"
 | 
						|
	"strings"
 | 
						|
 | 
						|
	"code.gitea.io/gitea/models"
 | 
						|
	"code.gitea.io/gitea/modules/log"
 | 
						|
	"code.gitea.io/gitea/modules/setting"
 | 
						|
	"code.gitea.io/gitea/modules/web/middleware"
 | 
						|
 | 
						|
	gouuid "github.com/google/uuid"
 | 
						|
)
 | 
						|
 | 
						|
// Ensure the struct implements the interface.
 | 
						|
var (
 | 
						|
	_ Method = &ReverseProxy{}
 | 
						|
	_ Named  = &ReverseProxy{}
 | 
						|
)
 | 
						|
 | 
						|
// ReverseProxy implements the Auth interface, but actually relies on
 | 
						|
// a reverse proxy for authentication of users.
 | 
						|
// On successful authentication the proxy is expected to populate the username in the
 | 
						|
// "setting.ReverseProxyAuthUser" header. Optionally it can also populate the email of the
 | 
						|
// user in the "setting.ReverseProxyAuthEmail" header.
 | 
						|
type ReverseProxy struct {
 | 
						|
}
 | 
						|
 | 
						|
// getUserName extracts the username from the "setting.ReverseProxyAuthUser" header
 | 
						|
func (r *ReverseProxy) getUserName(req *http.Request) string {
 | 
						|
	webAuthUser := strings.TrimSpace(req.Header.Get(setting.ReverseProxyAuthUser))
 | 
						|
	if len(webAuthUser) == 0 {
 | 
						|
		return ""
 | 
						|
	}
 | 
						|
	return webAuthUser
 | 
						|
}
 | 
						|
 | 
						|
// Name represents the name of auth method
 | 
						|
func (r *ReverseProxy) Name() string {
 | 
						|
	return "reverse_proxy"
 | 
						|
}
 | 
						|
 | 
						|
// Verify extracts the username from the "setting.ReverseProxyAuthUser" header
 | 
						|
// of the request and returns the corresponding user object for that name.
 | 
						|
// Verification of header data is not performed as it should have already been done by
 | 
						|
// the revese proxy.
 | 
						|
// If a username is available in the "setting.ReverseProxyAuthUser" header an existing
 | 
						|
// user object is returned (populated with username or email found in header).
 | 
						|
// Returns nil if header is empty.
 | 
						|
func (r *ReverseProxy) Verify(req *http.Request, w http.ResponseWriter, store DataStore, sess SessionStore) *models.User {
 | 
						|
	username := r.getUserName(req)
 | 
						|
	if len(username) == 0 {
 | 
						|
		return nil
 | 
						|
	}
 | 
						|
	log.Trace("ReverseProxy Authorization: Found username: %s", username)
 | 
						|
 | 
						|
	user, err := models.GetUserByName(username)
 | 
						|
	if err != nil {
 | 
						|
		if !models.IsErrUserNotExist(err) || !r.isAutoRegisterAllowed() {
 | 
						|
			log.Error("GetUserByName: %v", err)
 | 
						|
			return nil
 | 
						|
		}
 | 
						|
		user = r.newUser(req)
 | 
						|
	}
 | 
						|
 | 
						|
	// Make sure requests to API paths, attachment downloads, git and LFS do not create a new session
 | 
						|
	if !middleware.IsAPIPath(req) && !isAttachmentDownload(req) && !isGitRawOrLFSPath(req) {
 | 
						|
		if sess != nil && (sess.Get("uid") == nil || sess.Get("uid").(int64) != user.ID) {
 | 
						|
			handleSignIn(w, req, sess, user)
 | 
						|
		}
 | 
						|
	}
 | 
						|
	store.GetData()["IsReverseProxy"] = true
 | 
						|
 | 
						|
	log.Trace("ReverseProxy Authorization: Logged in user %-v", user)
 | 
						|
	return user
 | 
						|
}
 | 
						|
 | 
						|
// isAutoRegisterAllowed checks if EnableReverseProxyAutoRegister setting is true
 | 
						|
func (r *ReverseProxy) isAutoRegisterAllowed() bool {
 | 
						|
	return setting.Service.EnableReverseProxyAutoRegister
 | 
						|
}
 | 
						|
 | 
						|
// newUser creates a new user object for the purpose of automatic registration
 | 
						|
// and populates its name and email with the information present in request headers.
 | 
						|
func (r *ReverseProxy) newUser(req *http.Request) *models.User {
 | 
						|
	username := r.getUserName(req)
 | 
						|
	if len(username) == 0 {
 | 
						|
		return nil
 | 
						|
	}
 | 
						|
 | 
						|
	email := gouuid.New().String() + "@localhost"
 | 
						|
	if setting.Service.EnableReverseProxyEmail {
 | 
						|
		webAuthEmail := req.Header.Get(setting.ReverseProxyAuthEmail)
 | 
						|
		if len(webAuthEmail) > 0 {
 | 
						|
			email = webAuthEmail
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	user := &models.User{
 | 
						|
		Name:     username,
 | 
						|
		Email:    email,
 | 
						|
		IsActive: true,
 | 
						|
	}
 | 
						|
	if err := models.CreateUser(user); err != nil {
 | 
						|
		// FIXME: should I create a system notice?
 | 
						|
		log.Error("CreateUser: %v", err)
 | 
						|
		return nil
 | 
						|
	}
 | 
						|
 | 
						|
	return user
 | 
						|
}
 |