mirror of
https://github.com/go-gitea/gitea.git
synced 2026-06-08 04:23:40 +02:00
User-supplied CODEOWNERS patterns were compiled without a match timeout, so a crafted pattern (e.g. (a+)+) against a crafted file path could backtrack for tens of seconds inside the PR creation transaction and exhaust the database connection pool. Set MatchTimeout on each compiled rule; the caller already treats match errors as non-matches. --------- Signed-off-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
182 lines
4.9 KiB
Go
182 lines
4.9 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
||
// SPDX-License-Identifier: MIT
|
||
|
||
package issue
|
||
|
||
import (
|
||
"context"
|
||
"fmt"
|
||
"slices"
|
||
"time"
|
||
|
||
issues_model "gitea.dev/models/issues"
|
||
org_model "gitea.dev/models/organization"
|
||
user_model "gitea.dev/models/user"
|
||
"gitea.dev/modules/git"
|
||
"gitea.dev/modules/gitrepo"
|
||
"gitea.dev/modules/log"
|
||
"gitea.dev/modules/setting"
|
||
)
|
||
|
||
type ReviewRequestNotifier struct {
|
||
Comment *issues_model.Comment
|
||
IsAdd bool
|
||
Reviewer *user_model.User
|
||
ReviewTeam *org_model.Team
|
||
}
|
||
|
||
var codeOwnerFiles = []string{"CODEOWNERS", "docs/CODEOWNERS", ".gitea/CODEOWNERS"}
|
||
|
||
// codeOwnerMatchBudget caps the total wall-clock time spent evaluating all
|
||
// CODEOWNERS rules against all changed files for a single PR.
|
||
const codeOwnerMatchBudget = 2 * time.Second
|
||
|
||
func IsCodeOwnerFile(f string) bool {
|
||
return slices.Contains(codeOwnerFiles, f)
|
||
}
|
||
|
||
func PullRequestCodeOwnersReview(ctx context.Context, pr *issues_model.PullRequest) ([]*ReviewRequestNotifier, error) {
|
||
if err := pr.LoadIssue(ctx); err != nil {
|
||
return nil, err
|
||
}
|
||
issue := pr.Issue
|
||
if pr.IsWorkInProgress(ctx) {
|
||
return nil, nil
|
||
}
|
||
if err := pr.LoadHeadRepo(ctx); err != nil {
|
||
return nil, err
|
||
}
|
||
if err := pr.LoadBaseRepo(ctx); err != nil {
|
||
return nil, err
|
||
}
|
||
pr.Issue.Repo = pr.BaseRepo
|
||
|
||
if pr.BaseRepo.IsFork {
|
||
return nil, nil
|
||
}
|
||
|
||
repo, err := gitrepo.OpenRepository(ctx, pr.BaseRepo)
|
||
if err != nil {
|
||
return nil, err
|
||
}
|
||
defer repo.Close()
|
||
|
||
commit, err := repo.GetBranchCommit(pr.BaseRepo.DefaultBranch)
|
||
if err != nil {
|
||
return nil, err
|
||
}
|
||
|
||
var data string
|
||
for _, file := range codeOwnerFiles {
|
||
if blob, err := commit.GetBlobByPath(file); err == nil {
|
||
data, err = blob.GetBlobContent(setting.UI.MaxDisplayFileSize)
|
||
if err == nil {
|
||
break
|
||
}
|
||
}
|
||
}
|
||
if data == "" {
|
||
return nil, nil
|
||
}
|
||
|
||
rules, _ := issues_model.GetCodeOwnersFromContent(ctx, data)
|
||
if len(rules) == 0 {
|
||
return nil, nil
|
||
}
|
||
|
||
// get the mergebase
|
||
mergeBase, err := gitrepo.MergeBase(ctx, pr.BaseRepo, git.BranchPrefix+pr.BaseBranch, pr.GetGitHeadRefName())
|
||
if err != nil {
|
||
return nil, err
|
||
}
|
||
// https://github.com/go-gitea/gitea/issues/29763, we need to get the files changed
|
||
// between the merge base and the head commit but not the base branch and the head commit
|
||
changedFiles, err := repo.GetFilesChangedBetween(mergeBase, pr.GetGitHeadRefName())
|
||
if err != nil {
|
||
return nil, err
|
||
}
|
||
|
||
uniqUsers := make(map[int64]*user_model.User)
|
||
uniqTeams := make(map[string]*org_model.Team)
|
||
// Bound the total time spent matching rules×files. The per-rule MatchTimeout
|
||
// only caps a single match; without an aggregate budget a crafted CODEOWNERS
|
||
// plus a PR touching many files could still exhaust CPU inside this loop.
|
||
matchDeadline := time.Now().Add(codeOwnerMatchBudget)
|
||
ruleLoop:
|
||
for _, rule := range rules {
|
||
for _, f := range changedFiles {
|
||
if time.Now().After(matchDeadline) {
|
||
log.Warn("CODEOWNERS matching for PR %s#%d exceeded its time budget; some rules were not evaluated", pr.BaseRepo.FullName(), pr.ID)
|
||
break ruleLoop
|
||
}
|
||
shouldMatch := !rule.Negative
|
||
matched, _ := rule.Rule.MatchString(f) // err only happens when timeouts, any error can be considered as not matched
|
||
if matched == shouldMatch {
|
||
for _, u := range rule.Users {
|
||
uniqUsers[u.ID] = u
|
||
}
|
||
for _, t := range rule.Teams {
|
||
uniqTeams[fmt.Sprintf("%d/%d", t.OrgID, t.ID)] = t
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|
||
notifiers := make([]*ReviewRequestNotifier, 0, len(uniqUsers)+len(uniqTeams))
|
||
|
||
if err := issue.LoadPoster(ctx); err != nil {
|
||
return nil, err
|
||
}
|
||
|
||
// load all reviews from database
|
||
latestReviews, _, err := issues_model.GetReviewsByIssueID(ctx, pr.IssueID)
|
||
if err != nil {
|
||
return nil, err
|
||
}
|
||
|
||
contain := func(list issues_model.ReviewList, u *user_model.User) bool {
|
||
for _, review := range list {
|
||
if review.ReviewerTeamID == 0 && review.ReviewerID == u.ID {
|
||
return true
|
||
}
|
||
}
|
||
return false
|
||
}
|
||
|
||
for _, u := range uniqUsers {
|
||
if u.ID != issue.Poster.ID && !contain(latestReviews, u) {
|
||
comment, err := issues_model.AddReviewRequest(ctx, issue, u, issue.Poster, true)
|
||
if err != nil {
|
||
log.Warn("Failed add review user: %s to PR review: %s#%d, error: %s", u.Name, pr.BaseRepo.Name, pr.ID, err)
|
||
return nil, err
|
||
}
|
||
if comment == nil { // comment maybe nil if review type is ReviewTypeRequest
|
||
continue
|
||
}
|
||
notifiers = append(notifiers, &ReviewRequestNotifier{
|
||
Comment: comment,
|
||
IsAdd: true,
|
||
Reviewer: u,
|
||
})
|
||
}
|
||
}
|
||
|
||
for _, t := range uniqTeams {
|
||
comment, err := issues_model.AddTeamReviewRequest(ctx, issue, t, issue.Poster, true)
|
||
if err != nil {
|
||
log.Warn("Failed add reviewer team: %s to PR review: %s#%d, error: %s", t.Name, pr.BaseRepo.Name, pr.ID, err)
|
||
return nil, err
|
||
}
|
||
if comment == nil { // comment maybe nil if review type is ReviewTypeRequest
|
||
continue
|
||
}
|
||
notifiers = append(notifiers, &ReviewRequestNotifier{
|
||
Comment: comment,
|
||
IsAdd: true,
|
||
ReviewTeam: t,
|
||
})
|
||
}
|
||
|
||
return notifiers, nil
|
||
}
|