mirror of
https://github.com/go-gitea/gitea.git
synced 2026-08-21 21:35:32 +02:00
bircniandGitHub
ffd982c7ab
`FullSteps` only gave the synthetic "Complete job" step the remaining
log range when the last step that had run was also the final step of the
job. A skipped step does not count as having run, so any job ending in a
skipped step left the post step with an empty range: its logs were
stored but never rendered, and the duration showed as `0s`.
Reproducible with any job whose last step is skipped, which is common
for failure notifications:
```yaml
steps:
- run: echo hello
- run: echo never
if: failure()
```
The gate now checks whether the final step is done, which preserves the
behaviour from https://github.com/go-gitea/gitea/pull/29926 of showing
the post step as waiting while steps are still pending.
--> Regression from https://github.com/go-gitea/gitea/pull/29926
---------
Signed-off-by: bircni <bircni@icloud.com>
187 lines
7.7 KiB
Go
187 lines
7.7 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package actions
|
|
|
|
import (
|
|
"testing"
|
|
|
|
actions_model "gitea.dev/models/actions"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestFullSteps(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
task *actions_model.ActionTask
|
|
want []*actions_model.ActionTaskStep
|
|
}{
|
|
{
|
|
name: "regular",
|
|
task: &actions_model.ActionTask{
|
|
Steps: []*actions_model.ActionTaskStep{
|
|
{Status: actions_model.StatusSuccess, LogIndex: 10, LogLength: 80, Started: 10010, Stopped: 10090},
|
|
},
|
|
Status: actions_model.StatusSuccess,
|
|
Started: 10000,
|
|
Stopped: 10100,
|
|
LogLength: 100,
|
|
},
|
|
want: []*actions_model.ActionTaskStep{
|
|
{Name: preStepName, Status: actions_model.StatusSuccess, LogIndex: 0, LogLength: 10, Started: 10000, Stopped: 10010},
|
|
{Status: actions_model.StatusSuccess, LogIndex: 10, LogLength: 80, Started: 10010, Stopped: 10090},
|
|
{Name: postStepName, Status: actions_model.StatusSuccess, LogIndex: 90, LogLength: 10, Started: 10090, Stopped: 10100},
|
|
},
|
|
},
|
|
{
|
|
name: "failed step",
|
|
task: &actions_model.ActionTask{
|
|
Steps: []*actions_model.ActionTaskStep{
|
|
{Status: actions_model.StatusSuccess, LogIndex: 10, LogLength: 20, Started: 10010, Stopped: 10020},
|
|
{Status: actions_model.StatusFailure, LogIndex: 30, LogLength: 60, Started: 10020, Stopped: 10090},
|
|
{Status: actions_model.StatusCancelled, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
|
|
},
|
|
Status: actions_model.StatusFailure,
|
|
Started: 10000,
|
|
Stopped: 10100,
|
|
LogLength: 100,
|
|
},
|
|
want: []*actions_model.ActionTaskStep{
|
|
{Name: preStepName, Status: actions_model.StatusSuccess, LogIndex: 0, LogLength: 10, Started: 10000, Stopped: 10010},
|
|
{Status: actions_model.StatusSuccess, LogIndex: 10, LogLength: 20, Started: 10010, Stopped: 10020},
|
|
{Status: actions_model.StatusFailure, LogIndex: 30, LogLength: 60, Started: 10020, Stopped: 10090},
|
|
{Status: actions_model.StatusCancelled, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
|
|
{Name: postStepName, Status: actions_model.StatusFailure, LogIndex: 90, LogLength: 10, Started: 10090, Stopped: 10100},
|
|
},
|
|
},
|
|
{
|
|
name: "first step is running",
|
|
task: &actions_model.ActionTask{
|
|
Steps: []*actions_model.ActionTaskStep{
|
|
{Status: actions_model.StatusRunning, LogIndex: 10, LogLength: 80, Started: 10010, Stopped: 0},
|
|
},
|
|
Status: actions_model.StatusRunning,
|
|
Started: 10000,
|
|
Stopped: 10100,
|
|
LogLength: 100,
|
|
},
|
|
want: []*actions_model.ActionTaskStep{
|
|
{Name: preStepName, Status: actions_model.StatusSuccess, LogIndex: 0, LogLength: 10, Started: 10000, Stopped: 10010},
|
|
{Status: actions_model.StatusRunning, LogIndex: 10, LogLength: 80, Started: 10010, Stopped: 0},
|
|
{Name: postStepName, Status: actions_model.StatusWaiting, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
|
|
},
|
|
},
|
|
{
|
|
name: "first step has canceled",
|
|
task: &actions_model.ActionTask{
|
|
Steps: []*actions_model.ActionTaskStep{
|
|
{Status: actions_model.StatusCancelled, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
|
|
},
|
|
Status: actions_model.StatusFailure,
|
|
Started: 10000,
|
|
Stopped: 10100,
|
|
LogLength: 100,
|
|
},
|
|
want: []*actions_model.ActionTaskStep{
|
|
{Name: preStepName, Status: actions_model.StatusFailure, LogIndex: 0, LogLength: 100, Started: 10000, Stopped: 10100},
|
|
{Status: actions_model.StatusCancelled, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
|
|
{Name: postStepName, Status: actions_model.StatusFailure, LogIndex: 100, LogLength: 0, Started: 10100, Stopped: 10100},
|
|
},
|
|
},
|
|
{
|
|
name: "empty steps",
|
|
task: &actions_model.ActionTask{
|
|
Steps: []*actions_model.ActionTaskStep{},
|
|
Status: actions_model.StatusSuccess,
|
|
Started: 10000,
|
|
Stopped: 10100,
|
|
LogLength: 100,
|
|
},
|
|
want: []*actions_model.ActionTaskStep{
|
|
{Name: preStepName, Status: actions_model.StatusSuccess, LogIndex: 0, LogLength: 100, Started: 10000, Stopped: 10100},
|
|
{Name: postStepName, Status: actions_model.StatusSuccess, LogIndex: 100, LogLength: 0, Started: 10100, Stopped: 10100},
|
|
},
|
|
},
|
|
{
|
|
name: "all steps finished but task is running",
|
|
task: &actions_model.ActionTask{
|
|
Steps: []*actions_model.ActionTaskStep{
|
|
{Status: actions_model.StatusSuccess, LogIndex: 10, LogLength: 80, Started: 10010, Stopped: 10090},
|
|
},
|
|
Status: actions_model.StatusRunning,
|
|
Started: 10000,
|
|
Stopped: 0,
|
|
LogLength: 100,
|
|
},
|
|
want: []*actions_model.ActionTaskStep{
|
|
{Name: preStepName, Status: actions_model.StatusSuccess, LogIndex: 0, LogLength: 10, Started: 10000, Stopped: 10010},
|
|
{Status: actions_model.StatusSuccess, LogIndex: 10, LogLength: 80, Started: 10010, Stopped: 10090},
|
|
{Name: postStepName, Status: actions_model.StatusRunning, LogIndex: 90, LogLength: 10, Started: 10090, Stopped: 0},
|
|
},
|
|
},
|
|
{
|
|
name: "skipped task",
|
|
task: &actions_model.ActionTask{
|
|
Steps: []*actions_model.ActionTaskStep{
|
|
{Status: actions_model.StatusSkipped, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
|
|
},
|
|
Status: actions_model.StatusSkipped,
|
|
Started: 0,
|
|
Stopped: 0,
|
|
LogLength: 0,
|
|
},
|
|
want: []*actions_model.ActionTaskStep{
|
|
{Name: preStepName, Status: actions_model.StatusSkipped, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
|
|
{Status: actions_model.StatusSkipped, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
|
|
{Name: postStepName, Status: actions_model.StatusSkipped, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
|
|
},
|
|
},
|
|
{
|
|
name: "first step is skipped",
|
|
task: &actions_model.ActionTask{
|
|
Steps: []*actions_model.ActionTaskStep{
|
|
{Status: actions_model.StatusSkipped, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
|
|
{Status: actions_model.StatusSuccess, LogIndex: 10, LogLength: 80, Started: 10010, Stopped: 10090},
|
|
},
|
|
Status: actions_model.StatusSuccess,
|
|
Started: 10000,
|
|
Stopped: 10100,
|
|
LogLength: 100,
|
|
},
|
|
want: []*actions_model.ActionTaskStep{
|
|
{Name: preStepName, Status: actions_model.StatusSuccess, LogIndex: 0, LogLength: 10, Started: 10000, Stopped: 10010},
|
|
{Status: actions_model.StatusSkipped, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
|
|
{Status: actions_model.StatusSuccess, LogIndex: 10, LogLength: 80, Started: 10010, Stopped: 10090},
|
|
{Name: postStepName, Status: actions_model.StatusSuccess, LogIndex: 90, LogLength: 10, Started: 10090, Stopped: 10100},
|
|
},
|
|
},
|
|
{
|
|
name: "last step is skipped",
|
|
task: &actions_model.ActionTask{
|
|
Steps: []*actions_model.ActionTaskStep{
|
|
{Status: actions_model.StatusSuccess, LogIndex: 10, LogLength: 20, Started: 10010, Stopped: 10020},
|
|
{Status: actions_model.StatusSuccess, LogIndex: 30, LogLength: 60, Started: 10020, Stopped: 10090},
|
|
{Status: actions_model.StatusSkipped, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
|
|
},
|
|
Status: actions_model.StatusSuccess,
|
|
Started: 10000,
|
|
Stopped: 10100,
|
|
LogLength: 100,
|
|
},
|
|
want: []*actions_model.ActionTaskStep{
|
|
{Name: preStepName, Status: actions_model.StatusSuccess, LogIndex: 0, LogLength: 10, Started: 10000, Stopped: 10010},
|
|
{Status: actions_model.StatusSuccess, LogIndex: 10, LogLength: 20, Started: 10010, Stopped: 10020},
|
|
{Status: actions_model.StatusSuccess, LogIndex: 30, LogLength: 60, Started: 10020, Stopped: 10090},
|
|
{Status: actions_model.StatusSkipped, LogIndex: 0, LogLength: 0, Started: 0, Stopped: 0},
|
|
{Name: postStepName, Status: actions_model.StatusSuccess, LogIndex: 90, LogLength: 10, Started: 10090, Stopped: 10100},
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
assert.Equalf(t, tt.want, FullSteps(tt.task), "FullSteps(%v)", tt.task)
|
|
})
|
|
}
|
|
}
|