0
0
mirror of https://github.com/saltstack-formulas/salt-formula.git synced 2024-11-28 00:48:02 +01:00
salt-formula/salt
Raphaël Hertzog 97299983ba
Ensure consistent ordering of module_config entries
Right now when you set module_config entries in your pillar data
like this:
salt:
  minion:
    module_config:
      smtp.from: 'Kali Salt <admins+salt@kali.org>'
      smtp.to: 'Kali Admins <admins+salt@kali.org>'
      smtp.host: localhost
      smtp.subject: 'Results of salt actions on'
      smtp.fields: id,fun

On each run, you will always a different ordering of the various
fields in the minion configuration file, leading to spurious restart
of the minion and admin annoyance:

          ID: salt-minion
    Function: file.recurse
        Name: /etc/salt/minion.d
      Result: True
     Comment: Recursively updated /etc/salt/minion.d
     Started: 13:39:25.689775
    Duration: 874.318 ms
     Changes:
              ----------
              /etc/salt/minion.d/f_defaults.conf:
                  ----------
                  diff:
                      ---
                      +++
                      @@ -930,10 +930,10 @@
                       # A dict for the test module:
                       #test.baz: {spam: sausage, cheese: bread}
                       #
                      +smtp.fields: id,fun
                      +smtp.from: Kali Salt <admins+salt@kali.org>
                       smtp.to: Kali Admins <admins+salt@kali.org>
                      -smtp.fields: id,fun
                       smtp.host: localhost
                      -smtp.from: Kali Salt <admins+salt@kali.org>
                       smtp.subject: Results of salt actions on

With the change here, this bad behaviour is gone...
2021-04-09 16:02:36 +02:00
..
_mapdata test(map): verify map.jinja dump using _mapdata state 2020-12-23 18:21:53 +00:00
files Ensure consistent ordering of module_config entries 2021-04-09 16:02:36 +02:00
gitfs Fix for issue #361 2018-04-01 21:50:19 +10:00
pkgrepo fix(pkgrepo/suse/install): avoid managing repo if it already exists 2021-01-29 11:23:00 +00:00
api.sls fix(api): remove spurious colon in salt.api state 2020-04-03 10:07:46 +01:00
cloud.sls fix(tpl_path): replace slspath to tplroot 2020-02-13 09:43:25 +11:00
defaults.yaml refactor(retry_options): provide options from defaults/pillar 2021-03-30 12:40:40 +01:00
formulas.jinja feat(per-formula-opts): configure git.latest state per formula 2019-12-04 09:48:35 +11:00
formulas.sls fix(jinja): stop repeating user/group args 2020-09-11 23:27:30 +01:00
init.sls fix(windows): dont run master state 2020-09-11 20:53:00 +01:00
libtofs.jinja style(libtofs.jinja): use Black-inspired Jinja formatting [skip ci] 2020-07-19 23:28:36 +01:00
map.jinja fix(map.jinja): fix salt-lint errors 2019-10-09 18:34:12 +01:00
master.sls fix(freebsd): fix package names [skip ci] 2021-04-04 15:41:53 +01:00
minion.sls fix(freebsd): fix package names [skip ci] 2021-04-04 15:41:53 +01:00
osfamilymap.yaml fix(osfamilymap): use whoami for Windows rootuser 2021-03-30 12:02:12 +01:00
osmap.yaml fix(freebsd): fix package names [skip ci] 2021-04-04 15:41:53 +01:00
pin.sls feat(package): use apt-pinning to pin specific package version 2020-03-18 22:49:28 +03:00
ssh.sls fix(tpl_path): replace slspath to tplroot 2020-02-13 09:43:25 +11:00
standalone.sls feat(metastate): add metastate per community convention 2020-02-18 13:34:38 +00:00
syndic.sls fix(syndic.sls): fix salt-lint errors 2019-10-09 18:34:13 +01:00