Mirrors/gitea
0
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-06-27 02:02:48 +02:00
Code Issues Activity

fix: RecalculateUserAccess sets incorrect minMode for public repos

Browse Source 
Public repositories were granted AccessModeWrite as the minimum access
mode, which incorrectly elevated access for all users on public repos.
The minimum should be AccessModeNone, with access granted explicitly
through collaborator and team memberships.
This commit is contained in:
Ross Golder 2026-03-14 14:01:05 +07:00
parent edf0dfd1df
commit 667ddab36a
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
models/perm/access/access.go
View File

@ -231,10 +231,7 @@ func RecalculateTeamAccesses(ctx context.Context, repo *repo_model.Repository, i
// RecalculateUserAccess recalculates new access for a single user
// Usable if we know access only affected one user
func RecalculateUserAccess(ctx context.Context, repo *repo_model.Repository, uid int64) (err error) {
minMode := perm.AccessModeRead
if !repo.IsPrivate {
minMode = perm.AccessModeWrite
}
minMode := perm.AccessModeNone
accessMode := perm.AccessModeNone
e := db.GetEngine(ctx)