mirror of
				https://github.com/go-gitea/gitea.git
				synced 2025-11-03 23:54:25 +01:00 
			
		
		
		
	Improve External Wiki in Repo Header (#24304)
If you use a External Wiki, with Gitea, it brings currently 2 Problems
in the Header:
1. It always uses the Wiki Icon. When you use e.g. a External Issue
Tracker, it shows the External Link icon to Indicate, that the User will
send to a External Side. This helps preventing fishing.
2. If you use a External Wiki, the Link in the Header still goes to
`{repo}/wiki` which will redirect the user to the External Wiki. That
means, that if the users hovers with the Cursor over the link, it shows
`{repo}/wiki`, so the User does not know, where he will land.
This PR fixes both.

			
			
This commit is contained in:
		
							parent
							
								
									017a156553
								
							
						
					
					
						commit
						d347208114
					
				@ -215,12 +215,18 @@
 | 
			
		||||
				</a>
 | 
			
		||||
				{{end}}
 | 
			
		||||
 | 
			
		||||
				{{if or (.Permission.CanRead $.UnitTypeWiki) (.Permission.CanRead $.UnitTypeExternalWiki)}}
 | 
			
		||||
					<a class="{{if .PageIsWiki}}active {{end}}item" href="{{.RepoLink}}/wiki" {{if and (.Permission.CanRead $.UnitTypeExternalWiki) (not (StringUtils.HasPrefix ((.Repository.MustGetUnit $.Context $.UnitTypeExternalWiki).ExternalWikiConfig.ExternalWikiURL) (.Repository.Link)))}} target="_blank" rel="noopener noreferrer" {{end}}>
 | 
			
		||||
				{{if .Permission.CanRead $.UnitTypeWiki}}
 | 
			
		||||
					<a class="{{if .PageIsWiki}}active {{end}}item" href="{{.RepoLink}}/wiki">
 | 
			
		||||
						{{svg "octicon-book"}} {{.locale.Tr "repo.wiki"}}
 | 
			
		||||
					</a>
 | 
			
		||||
				{{end}}
 | 
			
		||||
 | 
			
		||||
				{{if .Permission.CanRead $.UnitTypeExternalWiki}}
 | 
			
		||||
					<a class="item" href="{{(.Repository.MustGetUnit $.Context $.UnitTypeExternalWiki).ExternalWikiConfig.ExternalWikiURL}}" target="_blank" rel="noopener noreferrer">
 | 
			
		||||
						{{svg "octicon-link-external"}} {{.locale.Tr "repo.wiki"}}
 | 
			
		||||
					</a>
 | 
			
		||||
				{{end}}
 | 
			
		||||
 | 
			
		||||
				{{if and (.Permission.CanReadAny $.UnitTypePullRequests $.UnitTypeIssues $.UnitTypeReleases) (not .IsEmptyRepo)}}
 | 
			
		||||
					<a class="{{if .PageIsActivity}}active {{end}}item" href="{{.RepoLink}}/activity">
 | 
			
		||||
						{{svg "octicon-pulse"}} {{.locale.Tr "repo.activity"}}
 | 
			
		||||
 | 
			
		||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user