8116742e2d
Fix viewed files number is not right if not all files loaded ( #35821 ) ( #35844 )
...
Fix #35803
Backport #35821
Signed-off-by: silverwind <me@silverwind.io >
Co-authored-by: silverwind <me@silverwind.io >
2025-11-03 17:19:50 -08:00
0a9cbf3228
upgrade go mail to 0.7.2 and fix the bug ( #35833 ) ( #35837 )
...
Backport #35833 by @lunny
patch from
https://github.com/wneessen/go-mail/issues/504#issuecomment-3477890515 .
Thanks to @wneessen
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2025-11-03 20:28:12 +00:00
74dfadb543
Fix circular spin animation direction ( #35785 ) ( #35823 )
...
Backport #35785 by @lutinglt
Wait for the status icon to rotate clockwise instead of counterclockwise
before:

after:

This can be merged to 1.25
Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com >
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com >
Co-authored-by: lutinglt <lutinglt@users.noreply.github.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-11-03 09:37:01 +00:00
8ffc1fbfbf
Revert gomail to v0.7.0 to fix sending mail failed ( #35816 ) ( #35824 )
...
Backport #35816 by @lunny
Revert gomail to the last work version to fix #35794
There is a problem between go mail v0.7.1 to prevent sending email work.
https://github.com/wneessen/go-mail/compare/v0.7.0...v0.7.1
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2025-11-03 09:08:13 +00:00
Giteabot and GitHub
e95378329b
Fix clone mixed bug ( #35810 ) ( #35822 )
2025-11-02 10:20:27 -08:00
fddf6cd63f
Fix cli "Before" handling ( #35797 ) ( #35808 )
...
Backport #35797 by @wxiaoguang
Regression of #34973
Fix #35796
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-31 22:00:14 +01:00
d253e2055b
Fix file extension on gogs.png ( #35793 ) ( #35799 )
...
Backport #35793 by @silverwind
During https://github.com/go-gitea/gitea/issues/35790 , it was noticed
that this PNG image had the wrong file extension. I also verified
`dingtalk.ico` and that one is actually an `.ico`.
Co-authored-by: silverwind <me@silverwind.io >
2025-10-31 03:33:27 +01:00
e194d89c74
Improve and fix markup code preview rendering ( #35777 ) ( #35787 )
...
Backport #35777 by @silverwind
1. Add the color on the link to the referenced file, which is the more
likely thing the user wants to click
2. Use monospace font on the SHA
3. Tweak text colors
4. Change SHA link to go to the commit instead of the repo root with
commit filter set
5. Added the repo name to the file link text
6. Fix broken line numbering rendering
The only major difference to GitHub is now the missing line numbers.
Before:
<img width="286" height="162" alt="Screenshot 2025-10-29 at 19 09 59"
src="https://github.com/user-attachments/assets/f16b4eec-caf2-4c31-a2b5-ae5f41747d4b "
/>
After:
<img width="378" height="157" alt="image"
src="https://github.com/user-attachments/assets/0c91dfd3-0910-4b2d-a43b-8c87cfbb933e "
/>
For comparison, GitHub rendering:
<img width="286" height="177" alt="image"
src="https://github.com/user-attachments/assets/8a9a07b7-9153-4415-9d7a-5685853e472a "
/>
Co-authored-by: silverwind <me@silverwind.io >
2025-10-30 09:06:44 +00:00
04b6f90889
Fix actions rerun bug ( #35783 ) ( #35784 )
...
Backport #35783
Fix #35780 , fix #35782
Rerunning a job or a run is only allowed when the job is done and the
run is done.
Related PR: #34970
https://github.com/go-gitea/gitea/blob/98ff7d077376db1225f266095788c6bd9414288a/routers/web/repo/actions/view.go#L239
We don't need to check run status again in `rerunJob` because the run
status has been changed before `rerunJob`.
---
In fact, the bug described in the above issues will not occur on the
main branch. Because `getRunJobs` is called before updating the run.
https://github.com/go-gitea/gitea/blob/98ff7d077376db1225f266095788c6bd9414288a/routers/web/repo/actions/view.go#L425-L435
So the run status that `rerunJob` checks is the old status.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-30 09:31:42 +01:00
65a37572f3
add pnpm to Snapcraft ( #35778 ) ( #35779 )
...
Backport #35778 by techknowlogick
Co-authored-by: techknowlogick <techknowlogick@gitea.com >
2025-10-29 19:35:18 +01:00
f85cd7aeb5
Fix actions schedule update issue ( #35767 ) ( #35774 )
...
Backport #35767 by @Zettat123
Fix #34472
Add integration tests for actions schedule update.
---------
Co-authored-by: Zettat123 <zettat123@gmail.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-29 18:51:16 +01:00
cf644d565d
Update release notes for 1.25.0 ( #35769 )
...
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
v1.25.0
2025-10-29 09:14:32 -07:00
Giteabot and GitHub
88a8571b93
Update tab title when navigating file tree ( #35757 ) ( #35772 )
...
Backport #35757 by bytedream
2025-10-29 14:04:19 +00:00
45a88e09af
Fix "ref-issue" handling in markup ( #35739 ) ( #35771 )
...
Backport #35739 by wxiaoguang
This is a follow up for #35662 , and also fix #31181 , help #30275 , fix
#31161
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-29 19:03:02 +08:00
Lunny Xiao and GitHub
6aa1a1e54d
Upgrade go mail to 0.7.2 ( #35748 ) ( #35750 )
...
backport #35748
2025-10-27 16:50:15 +00:00
18cc3160b5
Revert #18491 , fix oauth2 client link account ( #35745 ) ( #35751 )
...
Backport #35745 by @wxiaoguang
Fix #35744 by reverting #18491
* "OpenID" options don't mean "OAuth2Client" options
* "OAuth2(server)" options don't mean "OAuth2Client" options
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-26 15:26:40 -07:00
Lunny Xiao and GitHub
123c8d2b81
Fix review request webhook bug ( #35339 ) ( #35596 )
...
Frontport from #35339
2025-10-24 19:10:50 +00:00
wxiaoguang and GitHub
b2f2f8528a
Fix external render, make iframe render work ( #35727 , #35730 ) ( #35731 )
...
Backport #35727 and #35730
---------
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-23 16:07:17 +08:00
0925089b5e
Honor delete branch on merge repo setting when using merge API ( #35488 ) ( #35726 )
...
Backport #35488 by @kemzeb
Fix #35463 .
---------
Co-authored-by: Kemal Zebari <60799661+kemzeb@users.noreply.github.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-22 09:41:40 -07:00
c84d17b1bb
Don't block site admin's operation if SECRET_KEY is lost ( #35721 ) ( #35724 )
...
Backport #35721 by wxiaoguang
Related: #24573
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-22 05:02:47 +00:00
cb338a2ba1
fix attachment file size limit in server backend ( #35519 ) ( #35720 )
...
Backport #35519 by @a1012112796
fix #35512
Co-authored-by: a1012112796 <1012112796@qq.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-21 18:01:59 +00:00
16f4f0d473
Make restricted users can access public repositories ( #35693 ) ( #35719 )
...
Backport #35693 by wxiaoguang
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-21 15:35:41 +00:00
387a4e72f7
Fix various trivial problems ( #35714 ) ( #35718 )
...
Backport #35714 by wxiaoguang
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-21 18:02:57 +08:00
ac6d38e4b7
Refactor legacy code ( #35708 ) ( #35716 )
...
Backport #35708 by wxiaoguang
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-21 05:47:37 +00:00
6df51d4ef5
Avoid emoji mismatch and allow to only enable chosen emojis ( #35692 ) ( #35705 )
...
Backport #35692 by wxiaoguang
Fix #23635
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-20 08:29:02 +08:00
ChristopherHX and GitHub
46f695ac65
Fix workflow run event status while rerunning a failed job ( #35689 ) ( #35703 )
...
The event reported a completion status instead of requested, therefore
sent an email
Backport #35689
2025-10-19 10:49:20 -07:00
Giteabot and GitHub
4af1d58c86
Fix various bugs ( #35684 ) ( #35696 )
...
Backport #35684 by wxiaoguang
2025-10-19 02:26:03 +08:00
f71df88a6b
Use LFS object size instead of blob size when viewing a LFS file ( #35679 ) ( #35680 )
...
Backport #35679 by surya-purohit
shows the main LFS filesize instead of the pointer filesize when viewing
a file
Co-authored-by: Surya Purohit <suryaprakash.sharma@sourcefuse.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-16 22:41:24 +08:00
18b178e63f
Creating push comments before invoke pull request checking ( #35647 ) ( #35668 )
...
Backport #35647
This PR moved the creation of pushing comments before pull request
mergeable checking. So that when the pull request status changed, the
comments should have been created.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-15 17:42:52 +00:00
Lunny Xiao and GitHub
1644b8743c
Fix build ( #35674 )
...
backport #35656
2025-10-15 12:55:30 +00:00
wxiaoguang and GitHub
53a2aaee35
Fix missing Close when error occurs and abused connection pool ( #35658 ) ( #35670 )
...
Backport #35658
2025-10-15 09:56:53 +00:00
5ae9bb4df9
Fix a bug missed return ( #35655 ) ( #35667 )
...
Backport #35655 by @lunny
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2025-10-15 07:40:31 +02:00
ae2e8c1f00
Always create Actions logs stepsContainer ( #35654 ) ( #35672 )
...
Backport #35654 by wxiaoguang
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-15 04:16:06 +00:00
techknowlogick and GitHub
602af1499e
bump archives&rar dep ( #35637 ) ( #35638 )
2025-10-12 05:48:39 +02:00
f4512426a1
Fix code tag style problem and LFS view bug ( #35628 ) ( #35636 )
...
Backport #35628 by lutinglt
Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com >
Co-authored-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-11 20:25:03 +00:00
a3458c669a
The status icon of the Action step is consistent with GitHub ( #35618 ) ( #35621 )
...
Backport #35618 by @lutinglt
#35616
Before:
running:
<img width="45" height="34" alt="image"
src="https://github.com/user-attachments/assets/e2508f98-2f1f-4b7e-a80c-30b406f42531 "
/>
waiting:
<img width="44" height="33" alt="image"
src="https://github.com/user-attachments/assets/e7c8164e-fdc3-4546-b088-31166544edb0 "
/>
---
After:
running:
<img width="49" height="43" alt="image"
src="https://github.com/user-attachments/assets/b5a9b245-a995-458a-af23-d1723daa3692 "
/>
waiting:
<img width="42" height="44" alt="image"
src="https://github.com/user-attachments/assets/ff72551e-cfb5-4665-af52-938ef0cf8f1c "
/>
`gitea-running.svg` is not an icon from the @ primer/octicon library,
extracted from the Github page. Github did not assign a clear class name
to this icon
Signed-off-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com >
Co-authored-by: 鲁汀 <131967983+lutinglt@users.noreply.github.com >
Co-authored-by: lutinglt <lutinglt@users.noreply.github.com >
2025-10-10 12:12:21 -07:00
609d88f029
Fix inputing review comment will remove reviewer ( #35591 ) ( #35615 )
...
Backport #35591 by @lunny
Fix #34617
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2025-10-10 08:28:44 +00:00
3c78598217
Mock external service in hcaptcha TestCaptcha ( #35604 ) ( #35614 )
...
Backport #35604 by silverwind
The test calls out to a web service which may be down or unreachable as
seen in the linked issue. It's better for tests to not have such
external dependencies to make them absolutely stable.
Fixes: https://github.com/go-gitea/gitea/issues/35571
Co-authored-by: silverwind <me@silverwind.io >
2025-10-10 04:49:20 +00:00
b7bb0fa538
Fix diffpatch API endpoint ( #35610 ) ( #35613 )
...
Backport #35610 by @surya-purohit
Updates the swagger documentation for the `diffpatch` API endpoint.
The request body is corrected from the outdated `UpdateFileOptions` to
the current `ApplyDiffPatchOptions` to match the code implementation.
Closes [issue#35602](https://github.com/go-gitea/gitea/issues/35602 )
---------
Co-authored-by: Surya Purohit <suryaprakash.sharma@sourcefuse.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2025-10-10 03:28:40 +00:00
6de2151607
Fixing issue #35530 : Password Leak in Log Messages ( #35584 ) ( #35609 )
...
Backport #35584 by @shashank-netapp
# Summary
The Gitea codebase was logging `Elasticsearch` and `Meilisearch`
connection strings directly to log files without sanitizing them. Since
connection strings often contain credentials in the format
`protocol://username:password@host:port`, this resulted in passwords
being exposed in plain text in log output.
Fix:
- wrapped all instances of setting.Indexer.RepoConnStr and
setting.Indexer.IssueConnStr with the `util.SanitizeCredentialURLs()`
function before logging them.
Fixes : #35530
Co-authored-by: shashank-netapp <108022276+shashank-netapp@users.noreply.github.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2025-10-09 11:00:40 +02:00
a99761d466
Use inputs context when parsing workflows ( #35590 ) ( #35595 )
...
Backport #35590 by @Zettat123
Depends on [gitea/act#143 ](https://gitea.com/gitea/act/pulls/143 )
The [`inputs`
context](https://docs.github.com/en/actions/reference/workflows-and-actions/contexts#inputs-context )
is used when parsing workflows so that `run-name` like `run-name: Deploy
to ${{ inputs.deploy_target }}` can be parsed correctly.
Co-authored-by: Zettat123 <zettat123@gmail.com >
2025-10-06 22:28:17 +00:00
8d1c04bda4
Fix creating pull request failure when the target branch name is the same as some tag ( #35552 ) ( #35582 )
...
Backport #35552 by @lunny
Use full reference name in the git command to avoid ambiguity.
Fix #35470
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2025-10-06 06:10:52 +02:00
aa57531aac
fix: auto-expand and auto-scroll for actions logs ( #35583 ) ( #35586 )
...
Backport #35583 by ita004
Co-authored-by: Shafi Ahmed <98274448+ita004@users.noreply.github.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-05 12:06:41 +08:00
006fe2a907
Add rebase push display wrong comments bug ( #35560 ) ( #35580 )
...
Backport #35560 by @lunny
Fix #35518
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-04 10:28:32 +02:00
d94faf6d7e
fix(webhook): prevent tag events from bypassing branch filters targets ( #35567 ) ( #35577 )
...
Backport #35567 by Exgene
Co-authored-by: Kausthubh J Rao <105716675+Exgene@users.noreply.github.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: silverwind <me@silverwind.io >
2025-10-03 17:49:16 +00:00
6c8879b832
Fix markup init after issue comment editing ( #35536 ) ( #35537 )
...
Backport #35536 by wxiaoguang
Fix #35533
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-09-26 07:11:21 +08:00
Lunny Xiao and GitHub
94a6da3bc8
Add changelog for 1.25.0-rc0 ( #35531 )
v1.25.0-rc0
2025-09-25 09:32:30 -07:00
f09bea7af1
[Fix] Trigger 'unlabeled' event when label is Deleted from PR ( #34316 )
...
This pull request updates the handling of issue label events in
workflows to distinguish between label additions and deletions,
introduces corresponding test cases, and extends the `IssuePayload`
structure to support this functionality.
### Enhancements to issue label event handling:
* Updated `matchIssuesEvent` in `modules/actions/workflows.go` to
differentiate between "labeled" and "unlabeled" events based on whether
labels were added or removed.
* Added a new field, `RemovedLabels`, to the `IssuePayload` struct in
`modules/structs/hook.go` to track labels that were removed during an
issue event.
### Testing improvements:
* Added `TestMatchIssuesEvent` in `modules/actions/workflows_test.go` to
cover scenarios such as label addition, label deletion, and label
clearing, ensuring the correct event type is triggered.
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
v1.26.0-dev
2025-09-24 09:45:38 -07:00
GiteaBot
0b706b0825
[skip ci] Updated translations via Crowdin
2025-09-24 00:34:35 +00:00
Lunny Xiao and GitHub
198f37e33c
Move updateref and removeref to gitrepo and remove unnecessary open repository ( #35511 )
...
Extracted from #35077
`UpdateRef` and `RemoveRef` will call git commands even for gogit
version.
2025-09-19 08:04:18 -07:00