badhezi
b93c0c287c
test compliance
2025-10-08 13:12:44 +03:00
ecdce1800c
Update tests/integration/compare_test.go
...
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Signed-off-by: badhezi <zlilaharon@gmail.com >
2025-10-08 11:56:32 +03:00
7e6d45fd72
Update routers/web/repo/compare.go
...
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Signed-off-by: badhezi <zlilaharon@gmail.com >
2025-10-08 11:56:21 +03:00
badhezi
b9c62f2412
make head repo selection clearer
2025-10-08 11:55:40 +03:00
wxiaoguang and badhezi
d386cc8f54
FIXME: how to correctly choose the head repository?
2025-10-08 11:55:40 +03:00
wxiaoguang and badhezi
f39bad30d2
revert unnecessary change
2025-10-08 11:55:40 +03:00
badhezi
5764e20cc6
remove redundant line
2025-10-08 11:55:40 +03:00
badhezi
51f127729f
move revParse to testing code only
2025-10-08 11:55:40 +03:00
badhezi
b36fe3f554
add more test cases to cover different compare patterns
2025-10-08 11:55:40 +03:00
badhezi
1b8c1467c6
cover all head ref format cases
2025-10-08 11:55:40 +03:00
badhezi
ed642599e8
fix lint and typos
2025-10-08 11:55:40 +03:00
badhezi
35d23765e2
add download links to raw diff and patch in diff box options dropdown
2025-10-08 11:55:40 +03:00
badhezi
620153abf2
support tag and branch names with ends with .diff and .patch
2025-10-08 11:55:40 +03:00
badhezi
4a45253e26
fix timezone adjustment in TestCompareRawDiffPatch
2025-10-08 11:55:40 +03:00
badhezi
c5932f2257
formatting
2025-10-08 11:55:40 +03:00
badhezi
8300085cd4
Add tests and RevParse() function
2025-10-08 11:55:40 +03:00
badhezi
f531e40418
integration tests: WIP
2025-10-08 11:55:40 +03:00
badhezi
fc40f658da
lint, err handle
2025-10-08 11:55:40 +03:00
badhezi
11a0410bd8
parse .raw and .diff optional compare parameters
2025-10-08 11:55:40 +03:00
badhezi
c0e333eaa2
Revert "skip email notification trigger when run is not in final state"
...
This reverts commit 4e10abdb91 .
2025-10-08 11:55:22 +03:00
badhezi and GitHub
dcaeb90b37
Merge branch 'go-gitea:main' into main
2025-10-08 11:48:44 +03:00
badhezi
4e10abdb91
skip email notification trigger when run is not in final state
2025-10-08 11:38:43 +03:00
03fce8f3d0
Fixing issue #35530 : Password Leak in Log Messages ( #35584 )
...
The Gitea codebase was logging `Elasticsearch` and `Meilisearch`
connection strings directly to log files without sanitizing them. Since
connection strings often contain credentials in the format
`protocol://username:password@host:port`, this resulted in passwords
being exposed in plain text in log output.
Fix:
- wrapped all instances of setting.Indexer.RepoConnStr and
setting.Indexer.IssueConnStr with the `util.SanitizeCredentialURLs()`
function before logging them.
Fixes : #35530
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2025-10-07 09:26:47 -07:00
69f5ee970c
Move some functions to gitrepo package ( #35543 )
...
Refactor Git command functions to use WithXXX methods instead of
exposing RunOpts.
This change simplifies reuse across gitrepo and improves consistency,
encapsulation, and maintainability of command options.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-07 17:06:51 +08:00
c9e7fde8b3
feat: adds option to force update new branch in contents routes ( #35592 )
...
Allows users to specify a "force" option in API /contents routes when
modifying files in a new branch. When "force" is true, and the branch
already exists, a force push will occur provided the branch does not
have a branch protection rule that disables force pushing.
This is useful as a way to manage a branch remotely through only the
API. For example in an automated release tool you can pull commits,
analyze, and update a release PR branch all remotely without needing to
clone or perform any local git operations.
Resolve #35538
---------
Co-authored-by: Rob Gonnella <rob.gonnella@papayapay.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-06 21:23:14 -07:00
Lunny Xiao and GitHub
ad2ff67343
Move archive function to repo_model and gitrepo ( #35514 )
2025-10-06 15:01:26 -07:00
badhezi and GitHub
be195659f6
Merge branch 'go-gitea:main' into main
2025-10-06 15:53:29 +03:00
Zettat123 and GitHub
cdc0733047
Use inputs context when parsing workflows ( #35590 )
...
Depends on [gitea/act#143 ](https://gitea.com/gitea/act/pulls/143 )
The [`inputs`
context](https://docs.github.com/en/actions/reference/workflows-and-actions/contexts#inputs-context )
is used when parsing workflows so that `run-name` like `run-name: Deploy
to ${{ inputs.deploy_target }}` can be parsed correctly.
2025-10-06 06:09:27 +02:00
0a0baeb3b0
fix: auto-expand and auto-scroll for actions logs ( #35570 ) ( #35583 )
...
Implements reliable auto-expand and auto-scroll behavior for the Actions
logs view.
* Expands running or unfinished steps automatically.
* Smoothly scrolls to the latest log line during execution.
* Controlled via existing “Always auto-scroll” and “Expand running
steps” options.
Fixes #35570 .
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-05 10:31:06 +08:00
GiteaBot
851d8f9f7c
[skip ci] Updated translations via Crowdin
2025-10-05 00:38:21 +00:00
GiteaBot
4e7a97dea0
[skip ci] Updated translations via Crowdin
2025-10-04 00:32:04 +00:00
Lunny Xiao and GitHub
e1c2fef593
Fix creating pull request failure when the target branch name is the same as some tag ( #35552 )
...
Use full reference name in the git command to avoid ambiguity.
Fix #35470
2025-10-03 22:54:37 +00:00
silverwind and GitHub
6589326e96
Use bundled version of spectral ( #35573 )
...
To reduce the risk of npm supply chain attacks and to speed up
dependency installation, I've
[bundled](https://github.com/silverwind/spectral-cli-bundle ) the
spectral package into a zero-dependency module. The upstream package is
pretty dead currently, so I expect to keep up with their updates.
The package
[exports](https://github.com/silverwind/spectral-cli-bundle/blob/de05948c53a0a6f9690cdf65d35c3fc3324a583c/package.json#L9 )
a `spectral` bin script, so `pnpm exec spectral` continues to work
as-is.
In total, this removes 86 dependencies from the npm dependency tree.
2025-10-03 22:25:09 +00:00
17c8aa6587
Add rebase push display wrong comments bug ( #35560 )
...
Fix #35518
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-03 15:16:17 -07:00
wxiaoguang and GitHub
71360a94cb
Address some CodeQL security concerns ( #35572 )
...
Although there is no real security problem
2025-10-04 01:21:26 +08:00
badhezi and GitHub
80e3c30ec7
Merge branch 'go-gitea:main' into main
2025-10-03 12:38:38 +03:00
c4532101a4
fix(webhook): prevent tag events from bypassing branch filters targets #35449 ( #35567 )
...
Tag creation/deletion was triggering push webhooks even when branch
filters were configured, causing unintended pipeline executions.
This change modifies the branch filter logic to check the full ref
name directly instead of first determining if it's a "branch" event.
Fixes: Tag events now properly respect branch filters
- Add getPayloadRef() function to extract full ref names
- Update PrepareWebhook() to use direct ref matching
- Prevents refs/tags/* from matching refs/heads/* filters
Closes #35449
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: silverwind <me@silverwind.io >
2025-10-03 08:51:57 +02:00
efc48c36ff
Added button to copy file name in PR files ( #35509 )
...
The merge request file viewer has a button for copying the file path,
but it is not always convenient. Often, you only want to copy the file
name, which is currently not possible. This change request adds this
capability.
---------
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: a.kiselev <a.kiselev@reglab.ru >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-10-02 18:08:11 +00:00
silverwind and GitHub
340aed3982
Update JS and PY deps ( #35565 )
...
Updated all dependencies and did a quick test of the UI.
2025-10-02 08:45:56 +02:00
silverwind and GitHub
b907b9fb1a
Enable a few more tsconfig options ( #35553 )
...
Enable a few more useful options in tsconfig. `noImplicitReturns` had
two cases which I've fixed. Also, partially sort the file.
2025-09-30 21:43:41 -07:00
dependabot[bot] and GitHub
c5d74e5869
Bump github.com/wneessen/go-mail from 0.6.2 to 0.7.1 ( #35557 )
2025-10-01 00:14:53 +00:00
Steven Noonan and GitHub
c5332fdc55
add more routes to the "expensive" list ( #35547 )
...
Signed-off-by: Steven Noonan <steven@uplinklabs.net >
2025-09-29 17:33:28 +08:00
wxiaoguang and GitHub
0f668145e9
Drop json-iterator dependency ( #35544 )
2025-09-28 22:30:28 +08:00
6543 and GitHub
fbe80e6df2
Add proper error message if session provider can not be created ( #35520 )
...
the middleware that creates the session provider just panics if on
creation the config is wrong.
this is not catched and so you just get an cryptic stacktrace with no
point where to look at (as user).
## Before
```
2025/09/16 03:56:37 ...xer/stats/indexer.go:87:populateRepoIndexer() [I] Done (re)populating the repo stats indexer with existing repositories
2025/09/16 03:56:37 modules/ssh/ssh.go:387:Listen() [I] Adding SSH host key: /var/lib/gitea/data/ssh/gitea.rsa
2025/09/16 03:56:37 modules/ssh/init.go:26:Init() [I] SSH server started on :1234. Cipher list ([chacha20-poly1305@openssh.com aes128-ctr aes192-ctr aes256-ctr aes128-gcm@openssh.com aes256-gcm@openssh.com ]), key exchange algorithms ([curve25519-sha256 ecdh-sha2-nistp256 ecdh-sha2-nistp384 ecdh-sha2-nistp521 diffie-hellman-group14-sha256 diffie-hellman-group14-sha1]), MACs ([hmac-sha2-256-etm@openssh.com hmac-sha2-256 hmac-sha1])
2025/09/16 03:56:37 ...s/graceful/server.go:50:NewServer() [I] Starting new SSH server: tcp::1234 on PID: 83337
2025/09/16 03:56:38 cmd/web.go:231:func1() [F] PANIC: dial tcp 127.0.0.1:6379: connect: connection refused
gitea.com/go-chi/session@v0.0.0-20240316035857-16768d98ec96/session.go:239 (0x1cdb908)
code.gitea.io/gitea/routers/common/middleware.go:108 (0x2547f5a)
code.gitea.io/gitea/routers/web/web.go:270 (0x278b8e9)
code.gitea.io/gitea/routers/init.go:185 (0x2850d89)
code.gitea.io/gitea/cmd/web.go:211 (0x295c5ad)
code.gitea.io/gitea/cmd/web.go:262 (0x295cacb)
code.gitea.io/gitea/cmd/main.go:111 (0x2953422)
github.com/urfave/cli/v2@v2.27 .2/command.go:276 (0x1cc3dfd)
github.com/urfave/cli/v2@v2.27 .2/command.go:269 (0x1cc4084)
github.com/urfave/cli/v2@v2.27 .2/app.go:333 (0x1cc086a)
github.com/urfave/cli/v2@v2.27 .2/app.go:307 (0x2953f18)
code.gitea.io/gitea/cmd/main.go:172 (0x2953efc)
code.gitea.io/gitea/main.go:46 (0x2998498)
runtime/proc.go:283 (0x4471ca)
runtime/asm_amd64.s:1700 (0x484a20)
```
## After
```
2025/09/22 22:52:35 .../templates/htmlrenderer.go:118:initHTMLRenderer() [D] Creating static HTML Renderer
2025/09/22 22:52:35 routers/web/web.go:273:Routes() [F] common.Sessioner failed: failed to create session middleware: dial tcp 127.0.0.1:6379: connect: connection refused
```
---------
Signed-off-by: 6543 <6543@obermui.de >
2025-09-28 12:24:19 +00:00
151ef80e28
use experimental go json v2 library ( #35392 )
...
details: https://pkg.go.dev/encoding/json/v2
---------
Co-authored-by: techknowlogick <matti@mdranta.net >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-09-28 08:03:36 +00:00
Lunny Xiao and GitHub
8106d95577
Use global lock instead of status pool for cron lock ( #35507 )
2025-09-27 10:11:52 -07:00
Lunny Xiao and GitHub
1f32170060
Move some functions to gitrepo package ( #35503 )
2025-09-26 10:14:20 -07:00
7bf2972379
Move GetDiverging functions to gitrepo ( #35524 )
...
Extracted from #35469
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-09-26 15:15:42 +00:00
GiteaBot
8ad2a538da
[skip ci] Updated translations via Crowdin
2025-09-26 00:34:11 +00:00
Fabien Benetou and GitHub
53dfbbb2ee
Update issue.go with labels documentation (labels content, not ids) ( #35522 )
...
For https://github.com/go-gitea/gitea/issues/35521
---------
Signed-off-by: Fabien Benetou <fabien-services@benetou.fr >
2025-09-25 16:56:49 +00:00