mirror of
https://github.com/go-gitea/gitea.git
synced 2026-10-16 00:42:09 +02:00
wxiaoguang
2f1761e3fe
1. Remember the last token that has been rotated and skip its validation 2. Don't alarm when the token mismatch occurs in a short window
126 lines
3.6 KiB
Go
126 lines
3.6 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package auth
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
auth_model "gitea.dev/models/auth"
|
|
"gitea.dev/models/unittest"
|
|
"gitea.dev/modules/timeutil"
|
|
"gitea.dev/modules/util"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestCheckAuthToken(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
t.Run("Empty", func(t *testing.T) {
|
|
token, err := CheckAuthToken(t.Context(), "")
|
|
assert.ErrorIs(t, err, ErrAuthTokenInvalidFormat)
|
|
assert.Nil(t, token)
|
|
})
|
|
|
|
t.Run("InvalidFormat", func(t *testing.T) {
|
|
token, err := CheckAuthToken(t.Context(), "dummy")
|
|
assert.ErrorIs(t, err, ErrAuthTokenInvalidFormat)
|
|
assert.Nil(t, token)
|
|
})
|
|
|
|
t.Run("NotFound", func(t *testing.T) {
|
|
token, err := CheckAuthToken(t.Context(), "notexists:dummy")
|
|
assert.ErrorIs(t, err, ErrAuthTokenExpired)
|
|
assert.Nil(t, token)
|
|
})
|
|
|
|
t.Run("Expired", func(t *testing.T) {
|
|
timeutil.MockSet(time.Date(2023, 1, 1, 0, 0, 0, 0, time.UTC))
|
|
|
|
at, token, err := CreateAuthTokenForUserID(t.Context(), 2)
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, at)
|
|
assert.NotEmpty(t, token)
|
|
|
|
timeutil.MockUnset()
|
|
|
|
at2, err := CheckAuthToken(t.Context(), at.ID+":"+token)
|
|
assert.ErrorIs(t, err, ErrAuthTokenExpired)
|
|
assert.Nil(t, at2)
|
|
|
|
assert.NoError(t, auth_model.DeleteAuthTokenByID(t.Context(), at.ID))
|
|
})
|
|
|
|
t.Run("InvalidHash", func(t *testing.T) {
|
|
at, token, err := CreateAuthTokenForUserID(t.Context(), 2)
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, at)
|
|
assert.NotEmpty(t, token)
|
|
|
|
at2, err := CheckAuthToken(t.Context(), at.ID+":"+token+"dummy")
|
|
assert.ErrorIs(t, err, ErrAuthTokenInvalidHash)
|
|
assert.Nil(t, at2)
|
|
|
|
// a hash mismatch signals a compromised token, which must be revoked
|
|
_, err = auth_model.GetAuthTokenByID(t.Context(), at.ID)
|
|
assert.ErrorIs(t, err, util.ErrNotExist)
|
|
})
|
|
|
|
t.Run("Valid", func(t *testing.T) {
|
|
at, token, err := CreateAuthTokenForUserID(t.Context(), 2)
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, at)
|
|
assert.NotEmpty(t, token)
|
|
|
|
at2, err := CheckAuthToken(t.Context(), at.ID+":"+token)
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, at2)
|
|
|
|
assert.NoError(t, auth_model.DeleteAuthTokenByID(t.Context(), at.ID))
|
|
})
|
|
}
|
|
|
|
func TestRegenerateAuthToken(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
timeutil.MockSet(time.Date(2023, 1, 1, 0, 0, 0, 0, time.UTC))
|
|
defer timeutil.MockUnset()
|
|
|
|
at, token, err := CreateAuthTokenForUserID(t.Context(), 2)
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, at)
|
|
assert.NotEmpty(t, token)
|
|
|
|
timeutil.MockSet(time.Date(2023, 1, 1, 0, 0, 1, 0, time.UTC))
|
|
|
|
at2, token2, err := RegenerateAuthToken(t.Context(), at)
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, at2)
|
|
assert.NotEmpty(t, token2)
|
|
|
|
assert.Equal(t, at.ID, at2.ID)
|
|
assert.Equal(t, at.UserID, at2.UserID)
|
|
assert.NotEqual(t, token, token2)
|
|
assert.NotEqual(t, at.ExpiresUnix, at2.ExpiresUnix)
|
|
|
|
// A second request validated the same cookie before the first rotation.
|
|
_, _, err = RegenerateAuthToken(t.Context(), at)
|
|
require.ErrorIs(t, err, ErrAuthTokenStale)
|
|
|
|
_, err = CheckAuthToken(t.Context(), at.ID+":"+token)
|
|
require.ErrorIs(t, err, ErrAuthTokenStale)
|
|
current, err := CheckAuthToken(t.Context(), at2.ID+":"+token2)
|
|
require.NoError(t, err)
|
|
require.Equal(t, at2.TokenHash, current.TokenHash)
|
|
|
|
timeutil.MockSet(time.Date(2023, 1, 1, 0, 1, 2, 0, time.UTC))
|
|
_, err = CheckAuthToken(t.Context(), at.ID+":"+token)
|
|
require.ErrorIs(t, err, ErrAuthTokenInvalidHash)
|
|
_, err = auth_model.GetAuthTokenByID(t.Context(), at.ID)
|
|
require.ErrorIs(t, err, util.ErrNotExist)
|
|
assert.NoError(t, auth_model.DeleteAuthTokenByID(t.Context(), at.ID))
|
|
}
|