0
0
mirror of https://github.com/go-gitea/gitea.git synced 2024-11-28 04:08:25 +01:00
Go to file
Jason Song beb71f5ef6
Include public repos in doer's dashboard for issue search (#28304)
It will fix #28268 .

<img width="1313" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/cb1e07d5-7a12-4691-a054-8278ba255bfc">

<img width="1318" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/4fd60820-97f1-4c2c-a233-d3671a5039e9">

## ⚠️ BREAKING ⚠️

But need to give up some features:

<img width="1312" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/281c0d51-0e7d-473f-bbed-216e2f645610">

However, such abandonment may fix #28055 .

## Backgroud

When the user switches the dashboard context to an org, it means they
want to search issues in the repos that belong to the org. However, when
they switch to themselves, it means all repos they can access because
they may have created an issue in a public repo that they don't own.

<img width="286" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/182dcd5b-1c20-4725-93af-96e8dfae5b97">

It's a confusing design. Think about this: What does "In your
repositories" mean when the user switches to an org? Repos belong to the
user or the org?

Whatever, it has been broken by #26012 and its following PRs. After the
PR, it searches for issues in repos that the dashboard context user owns
or has been explicitly granted access to, so it causes #28268.

## How to fix it

It's not really difficult to fix it. Just extend the repo scope to
search issues when the dashboard context user is the doer. Since the
user may create issues or be mentioned in any public repo, we can just
set `AllPublic` to true, which is already supported by indexers. The DB
condition will also support it in this PR.

But the real difficulty is how to count the search results grouped by
repos. It's something like "search issues with this keyword and those
filters, and return the total number and the top results. **Then, group
all of them by repo and return the counts of each group.**"

<img width="314" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/5206eb20-f8f5-49b9-b45a-1be2fcf679f4">

Before #26012, it was being done in the DB, but it caused the results to
be incomplete (see the description of #26012).

And to keep this, #26012 implement it in an inefficient way, just count
the issues by repo one by one, so it cannot work when `AllPublic` is
true because it's almost impossible to do this for all public repos.


1bfcdeef4c/modules/indexer/issues/indexer.go (L318-L338)

## Give up unnecessary features

We may can resovle `TODO: use "group by" of the indexer engines to
implement it`, I'm sure it can be done with Elasticsearch, but IIRC,
Bleve and Meilisearch don't support "group by".

And the real question is, does it worth it? Why should we need to know
the counts grouped by repos?

Let me show you my search dashboard on gitea.com.

<img width="1304" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/2bca2d46-6c71-4de1-94cb-0c9af27c62ff">

I never think the long repo list helps anything.

And if we agree to abandon it, things will be much easier. That is this
PR.

## TODO

I know it's important to filter by repos when searching issues. However,
it shouldn't be the way we have it now. It could be implemented like
this.

<img width="1316" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/99ee5f21-cbb5-4dfe-914d-cb796cb79fbe">

The indexers support it well now, but it requires some frontend work,
which I'm not good at. So, I think someone could help do that in another
PR and merge this one to fix the bug first.

Or please block this PR and help to complete it.

Finally, "Switch dashboard context" is also a design that needs
improvement. In my opinion, it can be accomplished by adding filtering
conditions instead of "switching".
2023-12-07 13:26:18 +08:00
.devcontainer devpod use go1.21 (#26637) 2023-08-21 16:20:50 +00:00
.gitea Use docs.gitea.com instead of docs.gitea.io (#26739) 2023-08-27 11:59:12 +00:00
.github Check for v prefix on tags for release clean name (#28257) 2023-11-28 15:18:01 -06:00
assets bump go-deps (#27489) 2023-10-07 05:55:08 +00:00
build Use Set[Type] instead of map[Type]bool/struct{}. (#26804) 2023-08-30 06:55:25 +00:00
cmd Use db.Find instead of writing methods for every object (#28084) 2023-11-24 03:49:41 +00:00
contrib Update environment-to-ini flag parsing (#27914) 2023-11-06 21:36:58 +01:00
custom/conf add skip ci functionality (#28075) 2023-11-18 13:37:08 +02:00
docker Dockerfile small refactor (#27757) 2023-10-29 09:44:06 +08:00
docs Fix links in docs (#28302) 2023-12-01 19:42:42 +08:00
models Include public repos in doer's dashboard for issue search (#28304) 2023-12-07 13:26:18 +08:00
modules Include public repos in doer's dashboard for issue search (#28304) 2023-12-07 13:26:18 +08:00
options [skip ci] Updated translations via Crowdin 2023-12-07 00:24:32 +00:00
public Update JS and PY dependencies (#28120) 2023-11-20 01:02:57 +01:00
routers Include public repos in doer's dashboard for issue search (#28304) 2023-12-07 13:26:18 +08:00
services Fix migration panic due to an empty review comment diff (#28334) 2023-12-05 08:29:43 +00:00
snap set version in snapcraft yaml 2023-09-13 23:20:46 -04:00
templates Include public repos in doer's dashboard for issue search (#28304) 2023-12-07 13:26:18 +08:00
tests Add HEAD support for rpm repo files (#28309) 2023-12-05 08:01:02 +00:00
web_src Use appSubUrl for OAuth2 callback URL tip (#28266) 2023-11-29 01:37:12 +00:00
.air.toml
.changelog.yml Adapt .changelog.yml to new labeling system (#27701) 2023-10-20 00:22:00 +02:00
.dockerignore Move public asset files to the proper directory (#25907) 2023-07-18 18:06:43 +02:00
.editorconfig
.eslintrc.yaml Update JS and PY dependencies (#28120) 2023-11-20 01:02:57 +01:00
.gitattributes Move public asset files to the proper directory (#25907) 2023-07-18 18:06:43 +02:00
.gitignore update snap package (#27021) 2023-09-12 12:47:53 +00:00
.gitpod.yml
.golangci.yml Remove go versions from .golangci.yml (#27953) 2023-11-07 22:03:27 +01:00
.ignore Add /public/assets to .ignore (#26232) 2023-07-30 12:34:20 +02:00
.markdownlint.yaml Enable markdownlint no-duplicate-header (#27500) 2023-10-07 15:30:21 +02:00
.npmrc
.spectral.yaml
.stylelintrc.yaml Enable shorthands in declaration-strict-value linter (#27597) 2023-10-13 08:19:21 +00:00
.yamllint.yaml fully replace drone with actions (#27556) 2023-10-11 06:39:32 +00:00
BSDmakefile Fix build errors on BSD (in BSDMakefile) (#27594) 2023-10-13 15:38:27 +00:00
build.go
CHANGELOG.md Fix release link in changelog for v1.21.0 2023-11-14 15:03:49 +01:00
CODE_OF_CONDUCT.md
CONTRIBUTING.md Require clear descriptions both for feature and breaking PRs prior to the merge (#28112) 2023-11-19 09:53:31 +08:00
DCO
Dockerfile Dockerfile small refactor (#27757) 2023-10-29 09:44:06 +08:00
Dockerfile.rootless Dockerfile small refactor (#27757) 2023-10-29 09:44:06 +08:00
go.mod Remove SSH workaround (#27893) 2023-11-03 15:21:05 +00:00
go.sum Remove SSH workaround (#27893) 2023-11-03 15:21:05 +00:00
LICENSE
main.go Fix incorrect CLI exit code and duplicate error message (#26346) 2023-08-05 23:36:45 +08:00
MAINTAINERS Apply to become a maintainer (#27522) 2023-10-08 10:36:40 -04:00
Makefile Add --no-root to update-py (#27937) 2023-11-06 15:44:04 +00:00
package-lock.json Update JS and PY dependencies (#28120) 2023-11-20 01:02:57 +01:00
package.json Update JS and PY dependencies (#28120) 2023-11-20 01:02:57 +01:00
playwright.config.js
poetry.lock Update JS and PY dependencies (#28120) 2023-11-20 01:02:57 +01:00
poetry.toml
pyproject.toml Update JS and PY dependencies (#28120) 2023-11-20 01:02:57 +01:00
README_ZH.md Update readme to remove drone svg (#27624) 2023-10-14 16:11:54 +00:00
README.md Edit Discord Badge (#28188) 2023-11-23 19:58:12 -05:00
SECURITY.md fix wording in SECURITY.md (#27463) 2023-10-06 05:17:29 +08:00
vitest.config.js Use vitest globals (#27102) 2023-09-27 04:37:13 +00:00
webpack.config.js Enable production source maps for index.js, fix CSS sourcemaps (#27291) 2023-09-26 22:05:49 -04:00

Gitea

Gitea - Git with a cup of tea

Contribute with Gitpod

View this document in Chinese

Purpose

The goal of this project is to make the easiest, fastest, and most painless way of setting up a self-hosted Git service.

As Gitea is written in Go, it works across all the platforms and architectures that are supported by Go, including Linux, macOS, and Windows on x86, amd64, ARM and PowerPC architectures. You can try it out using the online demo. This project has been forked from Gogs since November of 2016, but a lot has changed.

Building

From the root of the source tree, run:

TAGS="bindata" make build

or if SQLite support is required:

TAGS="bindata sqlite sqlite_unlock_notify" make build

The build target is split into two sub-targets:

  • make backend which requires Go Stable, the required version is defined in go.mod.
  • make frontend which requires Node.js LTS or greater.

Internet connectivity is required to download the go and npm modules. When building from the official source tarballs which include pre-built frontend files, the frontend target will not be triggered, making it possible to build without Node.js.

Parallelism (make -j <num>) is not supported.

More info: https://docs.gitea.com/installation/install-from-source

Using

./gitea web

NOTE: If you're interested in using our APIs, we have experimental support with documentation.

Contributing

Expected workflow is: Fork -> Patch -> Push -> Pull Request

NOTES:

  1. YOU MUST READ THE CONTRIBUTORS GUIDE BEFORE STARTING TO WORK ON A PULL REQUEST.
  2. If you have found a vulnerability in the project, please write privately to security@gitea.io. Thanks!

Translating

Translations are done through Crowdin. If you want to translate to a new language ask one of the managers in the Crowdin project to add a new language there.

You can also just create an issue for adding a language or ask on discord on the #translation channel. If you need context or find some translation issues, you can leave a comment on the string or ask on Discord. For general translation questions there is a section in the docs. Currently a bit empty but we hope to fill it as questions pop up.

https://docs.gitea.com/contributing/localization

Crowdin

Further information

For more information and instructions about how to install Gitea, please look at our documentation. If you have questions that are not covered by the documentation, you can get in contact with us on our Discord server or create a post in the discourse forum.

We maintain a list of Gitea-related projects at gitea/awesome-gitea.

The official Gitea CLI is developed at gitea/tea.

Authors

Backers

Thank you to all our backers! 🙏 [Become a backer]

Sponsors

Support this project by becoming a sponsor. Your logo will show up here with a link to your website. [Become a sponsor]

FAQ

How do you pronounce Gitea?

Gitea is pronounced /ɡɪti:/ as in "gi-tea" with a hard g.

Why is this not hosted on a Gitea instance?

We're working on it.

License

This project is licensed under the MIT License. See the LICENSE file for the full license text.

Screenshots

Looking for an overview of the interface? Check it out!

Dashboard User Profile Global Issues
Branches Web Editor Activity
New Migration Migrating Pull Request View
Pull Request Dark Diff Review Dark Diff Dark